Remove FastClick #428
Remove FastClick #428
Conversation
There was a problem hiding this comment.
It seems that it is still needed: ftlabs/fastclick#514. I don't feel confident removing it yet.
| @@ -5,7 +5,6 @@ | |||
| width: 100%; | |||
| background: @app-bg; | |||
| overflow: hidden; | |||
| .translate3d(0,0,0); | |||
There was a problem hiding this comment.
Just curious, why is that better?
There was a problem hiding this comment.
The translate3d is used to force use of the GPU, but a side-effect of this is that the sidebar-right won't open on a desktop screen.
There was a problem hiding this comment.
I kinda can't reproduce it. It would be better to confirm it before. I'd say is at least a distinct bug.
|
If FastClick is still needed, then please use the patched version to avoid a freezing issue on iOS 11.3: |
|
I think we can try to update Fastclick once they merge this: ftlabs/fastclick#550. I honestly don't have much time to dedicate to this project, but I'll do my best to follow this matter. Also, I just noticed the ci broke again, ... not super happy with Travis lately, I'll check if I can quickly switch to Gitlab CI so tests would pass. |
See #427
FastClick is not needed in modern browsers, especially if you indicate that the page is optimized for mobile devices (either through the viewport meta-tag setting width=device-width, CSS of touch-action:manipulation or other means).