Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add maxInt in options #38

Merged
merged 2 commits into from
Aug 31, 2024
Merged

add maxInt in options #38

merged 2 commits into from
Aug 31, 2024

Conversation

balaji-atoa
Copy link
Contributor

@balaji-atoa balaji-atoa commented Aug 15, 2024 •
edited
Loading

💬BASED ON:

#2 (comment)

🚀UPDATES:

  • Added maxInt to be passable from options.

📋TESTCASES :

✅ Passing a valid value for maxInt parameter.
✅ Passing a invalid value throws an user friendly error.
✅ Passing a valid value for startFrom and maxInt parameters.
✅ Passing a same value for startFrom and maxInt parameters throws an user friendly error

❗BENCHMARK POST CHANGES:

image

mcollina
mcollina approved these changes Aug 15, 2024
View reviewed changes
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@balaji-atoa
Copy link
Contributor Author

balaji-atoa commented Aug 16, 2024 •
edited
Loading

@mcollina btw when it's gonna be shipped?

@mcollina mcollina merged commit 6177aa4 into mcollina:master Aug 31, 2024
10 checks passed
@mcollina
Copy link
Owner

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balaji-atoa @mcollina