Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does 4.x.x require Node 12? #51

Closed
bcoe opened this issue Oct 23, 2021 · 2 comments · Fixed by #52
Closed

Does 4.x.x require Node 12? #51

bcoe opened this issue Oct 23, 2021 · 2 comments · Fixed by #52

Comments

@bcoe
Copy link
Contributor

bcoe commented Oct 23, 2021

Does version 4.x.x require Node 12, if so mind adding an engines field?

I find this helpful because I can catch incompatibilities upstream by installing with npm i --engine-strict.
@mcollina
Copy link
Owner

Yes it does.

@mcollina
Copy link
Owner

I will add the field!

(It should work fine on v10 too).

mcollina added a commit that referenced this issue Oct 24, 2021
@mcollina
Add engines field. Add node 10.x to CI
5565ee4 
Fixes #51
@mcollina mcollina mentioned this issue Oct 24, 2021
Merged
mcollina added a commit that referenced this issue Oct 24, 2021
@mcollina
Add engines field. Add node 10.x to CI (#52)
beff8a0 
Fixes #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add engines field. Add node 10.x to CI mcollina/split2
2 participants
@mcollina @bcoe