Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite/Update Event docs #3299

Merged
merged 2 commits into from
Dec 12, 2021
Merged

Rewrite/Update Event docs #3299

merged 2 commits into from
Dec 12, 2021

Conversation

alattalatta
Copy link
Member

  • Markdown
    • 스쿼시 병합 하지 말아주세요.
  • 문서 재작성/업데이트

@alattalatta alattalatta requested a review from a team as a code owner December 9, 2021 11:31
@alattalatta alattalatta requested review from hochan222 and removed request for a team December 9, 2021 11:31
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Dec 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

Preview URLs

Flaws

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /ko/docs/Web/API/Event
Title: Event
on GitHub
Flaw count: 47

  • macros:
    • /ko/docs/Web/API/AudioProcessingEvent does not exist but fallbacked on /en-US/docs/Web/API/AudioProcessingEvent
    • /ko/docs/Web/API/BeforeUnloadEvent does not exist but fallbacked on /en-US/docs/Web/API/BeforeUnloadEvent
    • /ko/docs/Web/API/BlobEvent does not exist but fallbacked on /en-US/docs/Web/API/BlobEvent
    • /ko/docs/Web/API/CloseEvent does not exist but fallbacked on /en-US/docs/Web/API/CloseEvent
    • /ko/docs/Web/API/CompositionEvent does not exist but fallbacked on /en-US/docs/Web/API/CompositionEvent
    • and 39 more flaws omitted
  • broken_links:
    • Anchor not lowercase
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Web/API/Event/target
Title: Event.target
on GitHub
Flaw count: 2

  • macros:
    • /ko/docs/Web/API/Event/currentTarget does not exist but fallbacked on /en-US/docs/Web/API/Event/currentTarget
  • broken_links:
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Web/API/Event/Event
Title: Event()
on GitHub
Flaw count: 2

  • macros:
    • /ko/docs/Web/API/Event/composed does not exist but fallbacked on /en-US/docs/Web/API/Event/composed
  • broken_links:
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Web/API/Event/preventDefault
Title: Event.preventDefault()
on GitHub
Flaw count: 2

  • broken_links:
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (3 in common of 7 possible)

URL: /ko/docs/Web/API/Event/eventPhase
Title: Event.eventPhase
on GitHub
Flaw count: 4

  • macros:
    • /ko/docs/Web/API/HTMLHtmlElement does not exist but fallbacked on /en-US/docs/Web/API/HTMLHtmlElement
    • /ko/docs/Web/API/Event/bubbles does not exist but fallbacked on /en-US/docs/Web/API/Event/bubbles
    • /ko/docs/Web/API/Event/bubbles does not exist but fallbacked on /en-US/docs/Web/API/Event/bubbles
  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

External URLs

URL: /ko/docs/Web/API/Event
Title: Event
on GitHub

No new external URLs


URL: /ko/docs/Web/API/Event/cancelable
Title: Event.cancelable
on GitHub


URL: /ko/docs/Web/API/Event/stopPropagation
Title: Event.stopPropagation()
on GitHub

No new external URLs


URL: /ko/docs/Web/API/Event/target
Title: Event.target
on GitHub

No new external URLs


URL: /ko/docs/Web/API/Event/Event
Title: Event()
on GitHub

No new external URLs


URL: /ko/docs/Web/API/Event/preventDefault
Title: Event.preventDefault()
on GitHub

No new external URLs


URL: /ko/docs/Web/API/Event/stopImmediatePropagation
Title: Event.stopImmediatePropagation()
on GitHub

No new external URLs


URL: /ko/docs/Web/API/Event/eventPhase
Title: Event.eventPhase
on GitHub

No new external URLs


URL: /ko/docs/Web/API/Event/cancelBubble
Title: Event.cancelBubble
on GitHub

No new external URLs


URL: /ko/docs/Web/API/Event/isTrusted
Title: Event.isTrusted
on GitHub

No new external URLs

(this comment was updated 2021-12-09 11:34:08.372102)

Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alattalatta 님 안녕하세요, 리뷰드립니다.

아래 사항들은 크게 중요한 요소가 아니여서, 바로 병합하겠습니다.

1번, 2번, 3번에 대해서는 추후 처음 기여하는 분들을 위해 이슈를 따로 생성해서 그분들이 해결하도록 진행해도 괜찮을까요? 프로젝트 대쉬보드

감사합니다.

좋은 하루 보내세요 :)


  1. 원문 문단 누락
  • /docs/web/api/event
    • Legacy and non-standard properties 과 Deprecated methods 단원이 누락되었습니다.
  • /docs/web/api/event/cancelbubble
  1. trueture로 오타
  • /docs/web/api/event/istrusted
  1. ‘예제’ section title 빠짐.
  • /docs/web/api/event/preventdefault

@hochan222 hochan222 merged commit 5b75c39 into mdn:main Dec 12, 2021
@alattalatta alattalatta deleted the web/api/event branch December 12, 2021 16:34
@alattalatta
Copy link
Member Author

앗 오타... 진행하시려는 것은 좋습니다~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants