Add Custom Handshake Handlers for Websocket and EventSource Plugins #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Websocket Protocol has 2 main authentication schemes. Basic Authentication and Cookie Based Authentication. Therefore `Cookie` Header should be sent along the Connect Event.
This lets users to accept or reject event source request after checking the request headers. ( like a cookie )
Allows Cookie-based authentication strategies.
|
Added Custom Handshake Logic for AsyncEventSource Plugin. Allows Cookie based authentication at the handshake level. |
ayushsharma82
changed the title
|
Make sure to merge squash the branch. I've messed up this pull request by making lots of commits. 😆 |
|
Will test these thoroughly and then open a pull request. It will remain as a feature request. |
lorol
added a commit
to lorol/ESPAsyncWebServer
that referenced
this pull request
May 9, 2020
me-no-dev#684 For Websocket added: void handleHandshake(AwsHandshakeHandler handler) For EventSource added: void authorizeConnect(ArAuthorizeConnectHandler cb); Auth example and modifications. Tested on ESP8266 and ESP32 platforms See SmartSwitch.ino
Closed
Closed
DanielKnoop
pushed a commit
to DanielKnoop/ESPAsyncWebServer
that referenced
this pull request
Jun 17, 2022
me-no-dev#684 For Websocket added: void handleHandshake(AwsHandshakeHandler handler) For EventSource added: void authorizeConnect(ArAuthorizeConnectHandler cb); Auth example and modifications. Tested on ESP8266 and ESP32 platforms See SmartSwitch.ino
Zwer2k
pushed a commit
to Zwer2k/ESPAsyncWebServer
that referenced
this pull request
Jul 30, 2022
me-no-dev#684 For Websocket added: void handleHandshake(AwsHandshakeHandler handler) For EventSource added: void authorizeConnect(ArAuthorizeConnectHandler cb); Auth example and modifications. Tested on ESP8266 and ESP32 platforms See SmartSwitch.ino
Zwer2k
pushed a commit
to Zwer2k/ESPAsyncWebServer
that referenced
this pull request
Sep 11, 2022
me-no-dev#684 For Websocket added: void handleHandshake(AwsHandshakeHandler handler) For EventSource added: void authorizeConnect(ArAuthorizeConnectHandler cb); Auth example and modifications. Tested on ESP8266 and ESP32 platforms See SmartSwitch.ino
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Websocket Protocol has 2 main authentication schemes. Basic Authentication and Cookie Based Authentication. Therefore
CookieHeader should be sent along the Connect Event.