WIP: Dedicated reporter #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c39265a.
|
@krlmlr this looks like a similar idea for a dedicated area for the reporter. https://marketplace.visualstudio.com/items?itemName=emilylilylime.vscode-test-explorer-diagnostics |
meakbiyik
pushed a commit
that referenced
this pull request
Feb 20, 2022
* Package infrastructure * These files keep updating, not sure what to do about them * Tweak DESCRIPTION * Change license to MIT * Use testthat * Rename * Import infrastructure from testthat * Add TAP reporter as base * Tweak test infrastructure * Avoid teardown for now * Working test * Fix R CMD check * Rename reporter * Add first JSON output * More JSON * No contexts * Start and end test * Start and end reporter * Add result * File output, remove TAP * Remove context * Document * Revert "These files keep updating, not sure what to do about them" This reverts commit c39265a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have set up an R package infrastructure for easier testing. To run the reporter, it should be sufficient to source
reporter-vscode.Rand to runlibrary(testthat). Some internal code was borrowed from testthat.The output is in the
.mdfile. The format can be tweaked so that it's easier for the TypeScript side.Who should be responsible for aggregating the results within a test? Should R Test Explorer offer an even more fine-grained tree view to show every expectation?
Expectations can also run outside tests, how to handle that?
Do we still need to parse the test structure ourselves? The reporter gives file + line information for each expectation, we only need to find the surrounding
test_that()call.I think the TypeScript side should be responsible for creating the testRunId?
Something keeps changing a
.wasmand a.pngfile, I committed them here for now but these shouldn't be part of the PR.