Merge pull request #253 from mediaelement/release_3.0.1

release 3.0.1
mediaelement · Mar 11, 2024 · 3f621da · 3f621da
2 parents 6820c52 + 2e2841b
commit 3f621da
Show file tree

Hide file tree

Showing 9 changed files with 27 additions and 17 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,13 @@
 # Version History
 
+## *3.0.1 (2024/03/11)*
+### QUALITY PLUGIN
+* Icon Visibility Fix: The quality icon will now remain visible and functional across all quality adjustments.
+* Improved Option Naming: The option `iconPath` has been renamed to `iconPathQuality` to enhance clarity and consistency.
+
+### A11Y PLUGIN
+* Improved Option Naming: The option `iconSpritePath` has been renamed to `iconSpritePathA11y` to enhance clarity and consistency.
+
 ## *3.0.0 (2024/03/06)*
 ### QUALITY PLUGIN
 #### New Feature: Inline SVG icons for quality button

diff --git a/dist/a11y/a11y.js b/dist/a11y/a11y.js
@@ -33,7 +33,7 @@ Object.assign(mejs.MepDefaults, {
 
     audioDescriptionCanPlay: false,
 
-    iconSpritePath: 'mejs-a11y-icons.svg'
+    iconSpritePathA11y: 'mejs-a11y-icons.svg'
 });
 
 Object.assign(MediaElementPlayer.prototype, {
@@ -69,12 +69,12 @@ Object.assign(MediaElementPlayer.prototype, {
             return node.className.indexOf(className) > -1;
         });
     },
-    _generateIconHtml: function _generateIconHtml(id, classPrefix, iconSpritePath, iconId) {
-        return '<svg xmlns="http://www.w3.org/2000/svg" id="' + id + '" class="' + classPrefix + iconId + '" aria-hidden="true" focusable="false">\n            <use xlink:href="' + iconSpritePath + '#' + iconId + '"></use></svg>';
+    _generateIconHtml: function _generateIconHtml(id, classPrefix, iconSpritePathA11y, iconId) {
+        return '<svg xmlns="http://www.w3.org/2000/svg" id="' + id + '" class="' + classPrefix + iconId + '" aria-hidden="true" focusable="false">\n            <use xlink:href="' + iconSpritePathA11y + '#' + iconId + '"></use></svg>';
     },
     _createAudioDescription: function _createAudioDescription() {
         var t = this;
-        var iconHtml = t._generateIconHtml(t.id, t.options.classPrefix, t.options.iconSpritePath, 'icon-audio');
+        var iconHtml = t._generateIconHtml(t.id, t.options.classPrefix, t.options.iconSpritePathA11y, 'icon-audio');
         var audioDescriptionTitle = mejs.i18n.t('mejs.a11y-audio-description');
         var audioDescriptionButton = document.createElement('div');
         audioDescriptionButton.className = t.options.classPrefix + 'button ' + t.options.classPrefix + 'audio-description-button';
@@ -91,7 +91,7 @@ Object.assign(MediaElementPlayer.prototype, {
     },
     _createVideoDescription: function _createVideoDescription() {
         var t = this;
-        var iconHtml = t._generateIconHtml(t.id, t.options.classPrefix, t.options.iconSpritePath, 'icon-video');
+        var iconHtml = t._generateIconHtml(t.id, t.options.classPrefix, t.options.iconSpritePathA11y, 'icon-video');
         var videoDescriptionTitle = mejs.i18n.t('mejs.a11y-video-description');
         var videoDescriptionButton = document.createElement('div');
         videoDescriptionButton.className = t.options.classPrefix + 'button ' + t.options.classPrefix + 'video-description-button';

diff --git a/dist/a11y/a11y.min.js b/dist/a11y/a11y.min.js