Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes YouTube on iOS and Android #1383

Merged
merged 2 commits into from
Dec 10, 2014
Merged

Fixes YouTube on iOS and Android #1383

merged 2 commits into from
Dec 10, 2014

Conversation

OwenEdwards
Copy link
Contributor

Allow playback of YouTube videos on iOS and Android devices, where an issue in the YouTube iFrame player means that video playback on those OSes must be started by tapping directly on the iFrame (not via the API).

Restores the work-around for #1214 (which was broken by fb58904 -- see #1113).

Also, restores YouTube video playback window to full size of MediaElement window;
reverts 53810f5 (and efab12b).

@johndyer
Copy link
Collaborator

Thanks for all this.

I think it may be time for a more major restructuring soon but this really helps .

JD

On Nov 29, 2014, at 5:37 PM, Owen Edwards notifications@github.com wrote:

Allow playback of YouTube videos on iOS and Android devices, where an issue in the YouTube iFrame player means that video playback on those OSes must be started by tapping directly on the iFrame (not via the API).

Restores the work-around for #1214 (which was broken by fb58904 -- see #1113).

Also, restores YouTube video playback window to full size of MediaElement window;
reverts 53810f5 (and efab12b).

You can merge this Pull Request by running

git pull https://github.com/SmithKettlewellRERC/mediaelement YouTube-iOS-Android
Or view, comment on, or merge it at:

#1383

Commit Summary

Fix playback of YouTube videos on iOS and Android (which was broken by the fix to #1113)
Revert 53810f5
File Changes

M src/css/mediaelementplayer.css (2)
M src/js/mep-player.js (7)
Patch Links:

https://github.com/johndyer/mediaelement/pull/1383.patch
https://github.com/johndyer/mediaelement/pull/1383.diff

Reply to this email directly or view it on GitHub.

@OwenEdwards
Copy link
Contributor Author

Happy to help - appreciate all of what you and others have done on it to get it where it is today.

Let me know what "a more major restructuring" might be, and if there are ways I could help out.

@johndyer
Copy link
Collaborator

I'll have to double check the auto fields for <=IE8

johndyer added a commit that referenced this pull request Dec 10, 2014
@johndyer johndyer merged commit 1aed982 into mediaelement:master Dec 10, 2014
ale-grosselle pushed a commit to ale-grosselle/mediaelement that referenced this pull request Nov 25, 2016
…-iOS-Android

Fixes YouTube on iOS and Android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants