Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPORTANT] Moved to Wiktionary - Non english languages removed #102

Open
meetDeveloper opened this issue Aug 8, 2021 · 32 comments
Open

Comments

@meetDeveloper
Copy link
Owner

meetDeveloper commented Aug 8, 2021

tl;dr.

Hello,

I am planning to start using Wiktionary as source for Dictionary API. This will be an replacement to the current source, and due to this languages other than English will have to be dropped. Though for French and Spanish languages I will try to bring support soon.

The original texts of Wiktionary entries are dual-licensed to the public under both the Creative Commons Attribution-ShareAlike 3.0 Unported License (CC-BY-SA) and the GNU Free Documentation License (GFDL), more information about this here. Wiktionary sources information from these public domain sources.

Using Wiktionary as a source will help developers using my API a lot as they won't have to worry about using my API for commercial usage etc.

Currently Wiktionary for English language is pretty solid and we can rely on that, I have compared many entries and see no problem in using that as our source for English language.

The only downside I see is that the API will be exclusively for English language as for other languages as Wiktionary lags behind, but you can expect other languages to be added as soon as possible. Given that majority of users of this API are English speaking users, this change will affect relatively fewer users.

Users that need to have dictionary for other languages for their own personal use can use google search, google provides dictionary for many languages, I will add a detailed write up regarding how to search meaning for different languages on google later. In case you need an API to power your app, I suggest you to look at the Oxford Dictionary API, AFAIK they have Dictionary API that supports many languages.

I will maintain the structure of the API same and changes if any will only be additive in nature.

Thanking You
meetDeveloper

@rrbadam
Copy link

rrbadam commented Aug 9, 2021

Fine with it

@queleok
Copy link

queleok commented Aug 9, 2021

Would it be an additional source, or a replacement for the current one?

@meetDeveloper
Copy link
Owner Author

@queleok This will be an replacement.

@meetDeveloper
Copy link
Owner Author

Wikitionary uses following as sources: https://en.wiktionary.org/wiki/Wiktionary:Public_domain_sources

@queleok
Copy link

queleok commented Aug 9, 2021

I see, thank you, @meetDeveloper . I've tried analyzing the dictionary of 100k most frequently used English words according to the Wiktionary, there were some odd items like clearly French or German words. Of course, it's not a showstopper for the idea, so I guess it should be fine :)

@meetDeveloper meetDeveloper pinned this issue Aug 9, 2021
@meetDeveloper meetDeveloper changed the title Thinking of using wiktionary.org as source for Free Dictionary API. What are your thoughts? [IMPORTANT] Thinking of using wiktionary.org as source for Free Dictionary API. What are your thoughts? Aug 9, 2021
@meetDeveloper meetDeveloper changed the title [IMPORTANT] Thinking of using wiktionary.org as source for Free Dictionary API. What are your thoughts? [IMPORTANT] Will remove non english languages Aug 11, 2021
@phibr0
Copy link

phibr0 commented Aug 17, 2021

When will this change happen?

@ichmoimeyo
Copy link

HI

Have you checked out ...

https://yandex.com/dev/dictionary/
https://yandex.com/legal/dictionary_api/ FREE

http://www.collinslanguage.com/collins-api/ FREE -> 5000 p/m | £75p/m -> 30000 p/m

@meetDeveloper
Copy link
Owner Author

@ichmoimeyo They support English which I can get from Wiktionary.

@ichmoimeyo
Copy link

@ms-dc
Copy link

ms-dc commented Aug 31, 2021

any eta to non english language coming back? portuguese in particular

@piever
Copy link

piever commented Sep 11, 2021

The only downside I see is that the API will be exclusively for English language as for other languages as Wiktionary lags behind, but you can expect other languages to be added as soon as possible. Given that majority of users of this API are English speaking users, this change will affect relatively fewer users.

I confess I would love it if more languages were available. At a cursory look, it seems as if Wiktionary is reasonably good in other languages as well (I've just tested some random words on eg Italian, Portuguese and French and the definitions seem fine). Is the problem that the wiktionary API is inconsistent across languages?

Otherwise, I imagine it would cost relatively little to just support other languages as well (even if it turns that Wiktionary lags behind a bit on those, I guess it's still better than not supporting them at all).

@103sbavert
Copy link

103sbavert commented Sep 12, 2021

I can't complain as I pay 0 bucks to use this api but this will break my app. Brazilian Portuguese is already broken :'(

@OultimoCoder
Copy link

OultimoCoder commented Sep 13, 2021

Yeah I would really prefer the change didn't happen. I am using this API for a language flashcard app and this is super useful for dictionary definitions in a large variety of languages.

@1over137
Copy link

I really think there is no reason to do this. English Wiktionary has its own simple and easy to use API, but other languages are less structured. This is going to break the monolingual dictionary function in my app.

@ac-lap
Copy link

ac-lap commented Oct 26, 2021

Do we have an ETA by when this migration would be complete?

@arshsaxena
Copy link

Is this migration completed?

@meetDeveloper
Copy link
Owner Author

@arshsaxena @ac-lap @sbeve72 @OultimoCoder @piever This change will happen today. I hope to bring other languages soon but parsing Wiktionary for other languages is a bit difficult and will take some time.

@meetDeveloper
Copy link
Owner Author

This migration is completed. Now the API is only for English and using Wiktionary as source also I am sending in response sourceUrls from which the definitions have been parsed and the licenses.

@1over137
Copy link

I think this will make this API completely useless, as English Wiktionary already has its own API.

@phibr0
Copy link

phibr0 commented Feb 18, 2022

@arshsaxena @ac-lap @sbeve72 @OultimoCoder @piever This change will happen today. I hope to bring other languages soon but parsing Wiktionary for other languages is a bit difficult and will take some time.

If the API were open source I would really like to help here

@1over137
Copy link

wiktionary for other languages is a lot less structured though
i remember seeing other projects that parses russian or french ones.

@piever
Copy link

piever commented Feb 18, 2022

Thanks for the notification!

I imagine (correct me if I'm wrong) that at this point, this project is primarily a "conversion layer" between the Wiktionary API and the free dictionary API. Personally, I think that it is valuable, in that it was pretty straightforward for me to work with this API, but it looks like working directly with the Wiktionary API would have been harder.

Sorry about the slight off-topic, but I was wondering... Given that (from what I see in the README) it is costly to keep up servers that provide this API, would it make sense to package this as a plain module that one could load (say from CDN) and use it directly (to convert the result of calls to the Wiktionary API)?

@ngocsangyem
Copy link

Does the source code need to be updated @meetDeveloper ?

@meetDeveloper
Copy link
Owner Author

@ngocsangyem yes it needs to be updated.

@ngocsangyem
Copy link

It is very nice If you update the new source code soon. I need to make some customs for the API to host my app. @meetDeveloper

@meetDeveloper
Copy link
Owner Author

@piever Yes you are right, Wiktionary exposes dumps that anyone can parse and use it in their own work. I was also thinking to package this API in a plain module to avoid server costs, this is something I am exploring and will likely start work in few weeks.

@meetDeveloper meetDeveloper changed the title [IMPORTANT] Will remove non english languages [IMPORTANT] Moving to Wiktionary - Will remove non english languages Mar 6, 2022
@meetDeveloper meetDeveloper changed the title [IMPORTANT] Moving to Wiktionary - Will remove non english languages [IMPORTANT] Moved to Wiktionary - Non english languages removed Mar 6, 2022
@Etiene
Copy link

Etiene commented Apr 4, 2022

Yeah I would really prefer the change didn't happen. I am using this API for a language flashcard app and this is super useful for dictionary definitions in a large variety of languages.

I agree!

@spacelover1
Copy link

I want to use Oxford dictionary API and have trouble passing API key and ID. I get response using postman but in code it doesn't pass them. Anyone used this API?

Supinic added a commit to Supinic/supibot-package-manager that referenced this issue Oct 28, 2022
@abhagsain
Copy link

This migration is completed. Now the API is only for English and using Wiktionary as source also I am sending in response sourceUrls from which the definitions have been parsed and the licenses.

It'd be great if you merge your latest changes to master @meetDeveloper

@alexguillamon
Copy link

This is a useful project but others would like to run the server locally and or further make changes can you please push the latest changes to master? @meetDeveloper

@AndrewDiMola
Copy link

Has anyone created an adapted list of words that can be retrieved after the migration change? I used to use this file list as a source of truth, but because of the migration, a lot of words no longer retrieve results.

https://github.com/meetDeveloper/freeDictionaryAPI/blob/master/meta/wordList/english.txt

@KlavsKlavsen
Copy link

can anyone point to how to add a new language from wictionary to this? its really a great idea to use wictionary as source - hoping I can figure out how to add Hindi - so I can use this (and possibly improve - by using wictionary)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests