Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed import for EmbeddingBase class for ollama and huggingface embedders #1548

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

kmitul
Copy link
Contributor

@kmitul kmitul commented Jul 23, 2024

Description

Fixed import for EmbeddingBase class for ollama and huggingface embedders.

Fixes #1544

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2024

CLA assistant check
All committers have signed the CLA.

@Dev-Khant
Copy link
Collaborator

This looks good, thanks @kmitul.

@Dev-Khant Dev-Khant merged commit e287fb9 into mem0ai:main Aug 1, 2024
3 of 5 checks passed
@Dev-Khant Dev-Khant mentioned this pull request Aug 1, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'embedding'
3 participants