metrics: timer: update timer value on read #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2023 11:38
…unning * Add a test that confirms the behavior was broken (Test_TimerHearBeatReadWhileRunning) * Then fix the behavior and the test passes
LuskeyNoah
changed the title
|
Thank you @LuskeyNoah , we'll get this published! |
|
FYI this is scheduled for the upcoming 1.4.3 release, will update here once it's published! |
|
1.4.3 is now published, thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (debug) API
memfault_metrics_heartbeat_timer_readdoes not force an update of the timer value, which means that if it is used while the timer is running, the value read is stale.This change forces an update when the timer is read.