-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patternfile Support #193
Patternfile Support #193
Conversation
Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
yups fixing it |
@leecalcote the linting issue is due to the fact that I am using a variable in http.Get. But as I got to know right now(more like reminded),that a function for exactly this thing exists in meshery/models/walker which is to be moved to meshkit along with few other functions. So I am keeping this PR at hold, as soon as meshkit gets those functions with a new release. So the function causing the linting issue is going to get removed anyways. |
Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pattern support is urgently needed for ServiceMeshCon recording.
Notes from Utkarsh, "merging under the understanding that runtime generation is not likely to be working in this PR, however, this PR does contain prebuilt components that can be used for immediate demo." |
@Utkarsh-pro as soon as you put the gitwalker into meshkit, I can use that here and runtime component generation will start working. |
Description
This PR fixes #146
Static registration to be added
Notes for Reviewers
Signed commits