Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patternfile Support #193

Merged
merged 4 commits into from
Sep 11, 2021
Merged

Patternfile Support #193

merged 4 commits into from
Sep 11, 2021

Conversation

Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Sep 8, 2021

Description

This PR fixes #146

Static registration to be added
Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
@leecalcote leecalcote added this to the v0.6.0 milestone Sep 8, 2021
@leecalcote
Copy link
Member

Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
@Revolyssup
Copy link
Contributor Author

@Revolyssup Revolyssup added the pr/draft WIP/Draft pull request label Sep 8, 2021
@Revolyssup
Copy link
Contributor Author

@leecalcote the linting issue is due to the fact that I am using a variable in http.Get. But as I got to know right now(more like reminded),that a function for exactly this thing exists in meshery/models/walker which is to be moved to meshkit along with few other functions.

So I am keeping this PR at hold, as soon as meshkit gets those functions with a new release. So the function causing the linting issue is going to get removed anyways.

@Revolyssup Revolyssup added the pr/do-not-merge PRs not ready to be merged label Sep 9, 2021
Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pattern support is urgently needed for ServiceMeshCon recording.

@leecalcote
Copy link
Member

Notes from Utkarsh, "merging under the understanding that runtime generation is not likely to be working in this PR, however, this PR does contain prebuilt components that can be used for immediate demo."

@leecalcote leecalcote merged commit 534846e into meshery:master Sep 11, 2021
@Revolyssup
Copy link
Contributor Author

Notes from Utkarsh, "merging under the understanding that runtime generation is not likely to be working in this PR, however, this PR does contain prebuilt components that can be used for immediate demo."

@Utkarsh-pro as soon as you put the gitwalker into meshkit, I can use that here and runtime component generation will start working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/patterns pr/do-not-merge PRs not ready to be merged pr/draft WIP/Draft pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patternfile Support: Adapter Operation Registration in Meshery Server
2 participants