Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add statically generated pattern components for Consul #202

Merged
merged 5 commits into from
Oct 18, 2021

Conversation

DelusionalOptimist
Copy link
Contributor

Signed-off-by: Rudraksh Pareek rudrakshpareek3601@gmail.com

Description

This PR fixes #

Notes for Reviewers
Generated using much frowned upon and delusionally optimistic methods https://gist.github.com/DelusionalOptimist/7e870dc17bf80277b48cd840aaa0ca9d

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Rudraksh Pareek <rudrakshpareek3601@gmail.com>
Signed-off-by: Rudraksh Pareek <rudrakshpareek3601@gmail.com>
@leecalcote
Copy link
Member

Do we have a workflow in this repo to build components? @Revolyssup

@sayantan1413
Copy link
Member

sayantan1413 commented Oct 9, 2021

Hey @DelusionalOptimist I think you haven't attached the github workflow to generate this component. The update-oam-defs.yml one.

@sayantan1413
Copy link
Member

Oops sorry my bad Shreyas have already done that.

@DelusionalOptimist
Copy link
Contributor Author

Thank you for pointing this out @sayantan1413 @leecalcote. I'll update either of the PRs with a workflow 👍

@DelusionalOptimist
Copy link
Contributor Author

@Revolyssup I tried using the static components with this updated Docker image to check if they were getting registered. They were not.
Logs:

kubectl logs -n meshery meshery-consul-94fd7df9f-k4jz5 -f                         
{"app":"consul-adapter","level":"info","msg":"KUBECONFIG: /home/appuser/.meshery/kubeconfig.yaml","time":"2021-10-09T12:47:04Z"}
{"app":"consul-adapter","level":"info","msg":"Registering static workloads...","time":"2021-10-09T12:47:04Z"}
{"app":"consul-adapter","level":"info","msg":"Adaptor Listening at port: 10002","time":"2021-10-09T12:47:04Z"}
{"app":"consul-adapter","level":"info","msg":"Could not get manifest names json: cannot unmarshal number into Go struct field treeslice.tree of type string","time":"2021-10-09T12:47:05Z"}

Please look into this.

Signed-off-by: Rudraksh Pareek <rudrakshpareek3601@gmail.com>
@Revolyssup
Copy link
Contributor

@Revolyssup I tried using the static components with this updated Docker image to check if they were getting registered. They were not. Logs:

kubectl logs -n meshery meshery-consul-94fd7df9f-k4jz5 -f                         
{"app":"consul-adapter","level":"info","msg":"KUBECONFIG: /home/appuser/.meshery/kubeconfig.yaml","time":"2021-10-09T12:47:04Z"}
{"app":"consul-adapter","level":"info","msg":"Registering static workloads...","time":"2021-10-09T12:47:04Z"}
{"app":"consul-adapter","level":"info","msg":"Adaptor Listening at port: 10002","time":"2021-10-09T12:47:04Z"}
{"app":"consul-adapter","level":"info","msg":"Could not get manifest names json: cannot unmarshal number into Go struct field treeslice.tree of type string","time":"2021-10-09T12:47:05Z"}

Please look into this.

The error is from dynamic component registration and yes thats not working rn because that requires one of the functions which was to be moved to meshkit(the gitwalker function) Although static components are being registered with no problem

Signed-off-by: leecalcote <leecalcote@gmail.com>
@leecalcote
Copy link
Member

Upgrade to MeshKit v0.2.31 and golang v1.16.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big lift here!

@leecalcote leecalcote merged commit 4ce755d into master Oct 18, 2021
@leecalcote leecalcote deleted the DelusionalOptimist/chore/static-manifests branch October 18, 2021 21:38
@welcome
Copy link

welcome bot commented Oct 18, 2021

Thanks for your contribution to the Layer5 community! 🎉

Congrats!
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants