Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotating accepted gosec linter violation to be ignored by the linter #210

Merged
merged 1 commit into from
Oct 26, 2021
Merged

annotating accepted gosec linter violation to be ignored by the linter #210

merged 1 commit into from
Oct 26, 2021

Conversation

mgfeller
Copy link
Contributor

Signed-off-by: Michael Gfeller mgfeller@mgfeller.net

Description

This PR fixes #209

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Michael Gfeller <mgfeller@mgfeller.net>
Copy link
Contributor

@Revolyssup Revolyssup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@leecalcote leecalcote merged commit b1e5146 into meshery:master Oct 26, 2021
@leecalcote
Copy link
Member

Good deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix golangci-lint G107: Potential HTTP request made with variable url (gosec)
3 participants