Fix versioning issue and missing names | CU-2hr79nx #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
leecalcote
reviewed
Jul 8, 2022
| "github.com/layer5io/meshkit/utils/manifests" | ||
| smp "github.com/layer5io/service-mesh-performance/spec" | ||
| ) | ||
|
|
||
| type Versions struct { |
There was a problem hiding this comment.
Other adapters seem to be missing this struct. As we drive toward consistency across adapters, is there any reason that this struct is not standard?
There was a problem hiding this comment.
This is more like a utility struct for a very specific use case. This is not needed anywhere else.
There was a problem hiding this comment.
I politely and firmly reject this notion. Give me a ring.
leecalcote
changed the title
|
CU-2hr79nx |
leecalcote
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashish Tiwari ashishjaitiwari15112000@gmail.com
Description
This PR fixes #
Notes for Reviewers
Signed commits