Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/meshmode_metadata.json file renamed to meshmodel_metadata.json #359

Merged
merged 1 commit into from
Feb 17, 2023
Merged

build/meshmode_metadata.json file renamed to meshmodel_metadata.json #359

merged 1 commit into from
Feb 17, 2023

Conversation

deepakdinesh1123
Copy link
Contributor

Signed-off-by: deepakdinesh1123 d.deepakdinesh13@gmail.com

Notes for Reviewers
The build/meshmodel_metadata.json file was named meshmode_metadata.json, this PR fixes it.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: deepakdinesh1123 <d.deepakdinesh13@gmail.com>
@Revolyssup
Copy link
Contributor

Make sure you have make subsequent change in build/config.go where this file is used.

@deepakdinesh1123
Copy link
Contributor Author

@Revolyssup The build/config.go had the filename as meshmodel_metadata.json due to which it threw an Invalid argument error, so I renamed the file

@Revolyssup Revolyssup merged commit 1d2a953 into meshery:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants