Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the version check of golang #401

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Remove the version check of golang #401

merged 1 commit into from
Oct 12, 2023

Conversation

Aisuko
Copy link
Member

@Aisuko Aisuko commented Oct 12, 2023

Description

This PR fixes #

Notes for Reviewers

Manually check the if the adapter works well

KUBECONFIG: /home/codespace/.meshery/kubeconfig.yaml  app=consul-adapter
INFO[2023-10-12T02:18:23Z] Adaptor Listening at port: 10002              app=consul-adapter
INFO[2023-10-12T02:18:23Z] Registering static meshmodel components...    app=consul-adapter
INFO[2023-10-12T02:18:23Z] Registering latest workload components for version edge  app=consul-adapter
INFO[2023-10-12T02:18:23Z] Registering for auth.consul.hashicorp.com_trafficpermissions.yaml  app=consul-adapter
INFO[2023-10-12T02:18:24Z] auth.consul.hashicorp.com_trafficpermissions.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:24Z] Registering for consul.hashicorp.com_controlplanerequestlimits.yaml  app=consul-adapter
INFO[2023-10-12T02:18:24Z] consul.hashicorp.com_controlplanerequestlimits.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:24Z] Registering for consul.hashicorp.com_exportedservices.yaml  app=consul-adapter
INFO[2023-10-12T02:18:24Z] consul.hashicorp.com_exportedservices.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:24Z] Registering for consul.hashicorp.com_gatewayclassconfigs.yaml  app=consul-adapter
INFO[2023-10-12T02:18:25Z] consul.hashicorp.com_gatewayclassconfigs.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:25Z] Registering for consul.hashicorp.com_gatewaypolicies.yaml  app=consul-adapter
INFO[2023-10-12T02:18:25Z] consul.hashicorp.com_gatewaypolicies.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:25Z] Registering for consul.hashicorp.com_ingressgateways.yaml  app=consul-adapter
INFO[2023-10-12T02:18:25Z] consul.hashicorp.com_ingressgateways.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:25Z] Registering for consul.hashicorp.com_jwtproviders.yaml  app=consul-adapter
INFO[2023-10-12T02:18:25Z] consul.hashicorp.com_jwtproviders.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:25Z] Registering for consul.hashicorp.com_meshes.yaml  app=consul-adapter
INFO[2023-10-12T02:18:26Z] consul.hashicorp.com_meshes.yaml registered   app=consul-adapter
INFO[2023-10-12T02:18:26Z] Registering for consul.hashicorp.com_meshservices.yaml  app=consul-adapter
INFO[2023-10-12T02:18:26Z] consul.hashicorp.com_meshservices.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:26Z] Registering for consul.hashicorp.com_peeringacceptors.yaml  app=consul-adapter
INFO[2023-10-12T02:18:26Z] consul.hashicorp.com_peeringacceptors.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:26Z] Registering for consul.hashicorp.com_peeringdialers.yaml  app=consul-adapter
INFO[2023-10-12T02:18:27Z] consul.hashicorp.com_peeringdialers.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:27Z] Registering for consul.hashicorp.com_proxydefaults.yaml  app=consul-adapter
INFO[2023-10-12T02:18:27Z] consul.hashicorp.com_proxydefaults.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:27Z] Registering for consul.hashicorp.com_routeauthfilters.yaml  app=consul-adapter
INFO[2023-10-12T02:18:27Z] consul.hashicorp.com_routeauthfilters.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:27Z] Registering for consul.hashicorp.com_routeretryfilters.yaml  app=consul-adapter
INFO[2023-10-12T02:18:27Z] consul.hashicorp.com_routeretryfilters.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:27Z] Registering for consul.hashicorp.com_routetimeoutfilters.yaml  app=consul-adapter
INFO[2023-10-12T02:18:28Z] consul.hashicorp.com_routetimeoutfilters.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:28Z] Registering for consul.hashicorp.com_samenessgroups.yaml  app=consul-adapter
INFO[2023-10-12T02:18:28Z] consul.hashicorp.com_samenessgroups.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:28Z] Registering for consul.hashicorp.com_servicedefaults.yaml  app=consul-adapter
INFO[2023-10-12T02:18:28Z] consul.hashicorp.com_servicedefaults.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:28Z] Registering for consul.hashicorp.com_serviceintentions.yaml  app=consul-adapter
INFO[2023-10-12T02:18:29Z] consul.hashicorp.com_serviceintentions.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:29Z] Registering for consul.hashicorp.com_serviceresolvers.yaml  app=consul-adapter
INFO[2023-10-12T02:18:29Z] consul.hashicorp.com_serviceresolvers.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:29Z] Registering for consul.hashicorp.com_servicerouters.yaml  app=consul-adapter
INFO[2023-10-12T02:18:29Z] consul.hashicorp.com_servicerouters.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:29Z] Registering for consul.hashicorp.com_servicesplitters.yaml  app=consul-adapter
INFO[2023-10-12T02:18:29Z] consul.hashicorp.com_servicesplitters.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:29Z] Registering for consul.hashicorp.com_terminatinggateways.yaml  app=consul-adapter
INFO[2023-10-12T02:18:30Z] consul.hashicorp.com_terminatinggateways.yaml registered  app=consul-adapter
INFO[2023-10-12T02:18:30Z] Component creation completed for version v1.3.0-rc1  app=consul-adapter
INFO[2023-10-12T02:18:30Z] Registering workloads with Meshery Server for version v1.3.0-rc1  app=consul-adapter

Signed commits

  • Yes, I signed my commits.

@Aisuko Aisuko self-assigned this Oct 12, 2023
@Aisuko Aisuko added the area/lifecycle Lifecycle management (install, uninstall, configure) related label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@Aisuko
Remove no exist env test
9a62b1d 
Signed-off-by: GitHub <noreply@github.com>
Aisuko
Aisuko commented Oct 12, 2023
View reviewed changes
Copy link
Member Author

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@Aisuko Aisuko merged commit 81317eb into master Oct 12, 2023
5 of 9 checks passed
@Aisuko Aisuko deleted the feat/merge branch October 12, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Aisuko Aisuko

Labels
area/lifecycle Lifecycle management (install, uninstall, configure) related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Aisuko