Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Upgrade to Go 1.19 #180

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Upgrade to Go 1.19 #180

merged 3 commits into from
Oct 5, 2022

Conversation

acald-creator
Copy link
Contributor

@acald-creator acald-creator commented Sep 17, 2022 •
edited
Loading

Signed-off-by: Antonette Caldwell pullmana8@gmail.com

Description

This PR is related to meshery/meshery#6220

  • Upgrade to Go 1.19
  • Updated template content and paths, as OSM have moved to a newer version and newer location

Notes for Reviewers

Signed commits

  • [ x ] Yes, I signed my commits.

@welcome
Copy link

welcome bot commented Sep 17, 2022

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@acald-creator acald-creator added area/ci Continuous integration | Build and release language/go Golang related kind/enhancement Improvement in current feature and removed area/ci Continuous integration | Build and release labels Sep 17, 2022
@acald-creator
Upgrade to Go 1.19
e16aa75 
Signed-off-by: Antonette Caldwell <pullmana8@gmail.com>
leecalcote
leecalcote suggested changes Sep 24, 2022
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Merge conflict...

@leecalcote
Copy link
Member

Some high quality work here. 🥇

@acald-creator
Copy link
Contributor Author

Sometimes I hate making changes via GitHub

@leecalcote
Copy link
Member

go.sum reconciliation on the web interface would be a nightmare.

@acald-creator, if you haven't tried this before, you might get a kick out of it: Press ..

@acald-creator acald-creator reopened this Sep 24, 2022
@acald-creator
Copy link
Contributor Author

took longer than i thought but i got it back open

@leecalcote
Copy link
Member

@Revolyssup please review.

@acald-creator acald-creator force-pushed the v1.19-upgrade branch 3 times, most recently from 6aebc13 to 97f8898 Compare September 27, 2022 03:08
@acald-creator
Merge remote-tracking branch 'origin/v1.19-upgrade' into v1.19-upgrade
dc8bfbf 
Signed-off-by: Antonette Caldwell <pullmana8@gmail.com>
@leecalcote
Copy link
Member

@Revolyssup please review.

No review to offer, @Revolyssup?

@leecalcote @acald-creator
MeshKit upgrade
ac4b087 
Signed-off-by: leecalcote <leecalcote@gmail.com>
Signed-off-by: Antonette Caldwell <pullmana8@gmail.com>
@leecalcote
Copy link
Member

@Revolyssup please review.

No review to offer, @Revolyssup?

Calling on @Revolyssup...

@Revolyssup Revolyssup merged commit 53ea822 into meshery:master Oct 5, 2022
@welcome
Copy link

welcome bot commented Oct 5, 2022

Thanks for your contribution to the Layer5 community! 🎉

Congrats!
        ⭐ Please star the project. 😄 if you have yet to do so.

@acald-creator acald-creator deleted the v1.19-upgrade branch October 5, 2022 22:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leecalcote leecalcote leecalcote requested changes

@Revolyssup Revolyssup Revolyssup approved these changes

Assignees
No one assigned
Labels
kind/enhancement Improvement in current feature language/go Golang related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acald-creator @leecalcote @Revolyssup