Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

#206-Update Slack & Community logo links #207

Merged
merged 3 commits into from
Nov 28, 2022
Merged

#206-Update Slack & Community logo links #207

merged 3 commits into from
Nov 28, 2022

Conversation

jasonjg
Copy link
Contributor

@jasonjg jasonjg commented Nov 24, 2022 •
edited
Loading

Signed-off-by: Jason Galbiso jasongcodes@gmail.com

Description

This PR fixes #206

Notes for Reviewers

The README.md Community and Slack logos had their href links switched. I updated them so that clicking on the Slack logo redirects to http://slack.layer5.io and clicking on the Community logo (3 green figures) redirects to https://meshery.io/community

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented Nov 24, 2022

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@leecalcote
Copy link
Member

Thank you, @jasonjg 👍

UtkarshMishra12
UtkarshMishra12 suggested changes Nov 24, 2022
View reviewed changes
Copy link
Member

@UtkarshMishra12 UtkarshMishra12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please fix the broken "build status" image?

README.md Outdated
@@ -38,9 +38,9 @@ alt="Meshery - the Service Mesh Management Plane" align="left" /></a>
<h2><a name="contributing"></a><a name="community"></a> <a href="http://slack.layer5.io">Community</a> and <a href="https://github.com/layer5io/layer5/blob/master/CONTRIBUTING.md">Contributing</a></h2>
Our projects are community-built and welcome collaboration. 👍 Be sure to see the <a href="https://docs.google.com/document/d/17OPtDE_rdnPQxmk2Kauhm3GwXF1R5dZ3Cj8qZLKdo5E/edit">Layer5 Community Welcome Guide</a> for a tour of resources available to you and jump into our <a href="http://slack.layer5.io">Slack</a>! Contributors are expected to adhere to the <a href="https://github.com/cncf/foundation/blob/master/code-of-conduct.md">CNCF Code of Conduct</a>.

<a href="https://meshery.io/community"><img alt="Layer5 Service Mesh Community" src="https://raw.githubusercontent.com/layer5io/meshery-osm/master/img/readme/slack-128.png" style="margin-left:10px;padding-top:5px;" width="110px" align="right" /></a>
<a href="http://slack.layer5.io"><img alt="Layer5 Service Mesh Community" src="https://raw.githubusercontent.com/layer5io/meshery-osm/master/img/readme/slack-128.png" style="margin-left:10px;padding-top:5px;" width="110px" align="right" /></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make it https rather than http?

Copy link
Contributor Author

@jasonjg jasonjg Nov 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I just switched the links that were already there.

@jasonjg
Copy link
Contributor Author

jasonjg commented Nov 24, 2022 •
edited
Loading

Can you also please fix the broken "build status" image?

I'm unable to locate badge.svg.

The link for the asset points to a directory named "workflows" in the main meshery-osm directory. However, that directory is not there, and badge.svg is not found in the meshery-osm repository.

Line 9: https://github.com/layer5io/meshery-osm/workflows/Meshery%20OSM/badge.svg

@UtkarshMishra12
Copy link
Member

@leecalcote Can you please guide him?

@UtkarshMishra12
Copy link
Member

@jasonjg Try using this Link

@jasonjg
Copy link
Contributor Author

jasonjg commented Nov 25, 2022

@jasonjg Try using this Link

Thanks for your guidance. I'll look more into shields.io and learn how to use it.

@UtkarshMishra12
Copy link
Member

@jasonjg Can you please signed-off your commits by following the instructions on this page?
or
In your local branch, run: git rebase HEAD~3 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin jasonjg/update-logo-links

@jasonjg
meshery#206-Update Slack & Community logo links
7a7c322 
Signed-off-by: Jason Galbiso <jasongcodes@gmail.com>
@jasonjg
meshery#206-Change slack link to https
69beebf 
Signed-off-by: Jason Galbiso <jasongcodes@gmail.com>
@jasonjg
update README.MD Build Status .svg link
7390643 
Signed-off-by: Jason Galbiso <jasongcodes@gmail.com>
UtkarshMishra12
UtkarshMishra12 approved these changes Nov 27, 2022
View reviewed changes
Copy link
Member

@UtkarshMishra12 UtkarshMishra12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , Nice work @jasonjg 😎

@leecalcote leecalcote merged commit 2205b4b into meshery:master Nov 28, 2022
@welcome
Copy link

welcome bot commented Nov 28, 2022

Thanks for your contribution to the Layer5 community! 🎉

Congrats!
        ⭐ Please star the project. 😄 if you have yet to do so.

@leecalcote
Copy link
Member

Yay, @jasonjg! 🎈 💯

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@UtkarshMishra12 UtkarshMishra12 UtkarshMishra12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken Build status Image/SVG
3 participants
@jasonjg @leecalcote @UtkarshMishra12