added svg in config.yml #244
Conversation
|
@ShivangShandilya please review my request again |
LGTM 👍 |
.github/config.yml
Outdated
| <picture> | ||
| <source media="(prefers-color-scheme: dark)" srcset="img\readme\meshery-text-dark.svg"> | ||
| <source media="(prefers-color-scheme: light)" srcset="img\readme\meshery-text-light.svg"> | ||
| <img alt="Shows a black logo in light color mode and a white one in dark color mode." src="https://user-images.githubusercontent.com/25423296/163456779-a8556205-d0a5-45e2-ac17-42d089e3c3f8.png"> | ||
| </picture> |
There was a problem hiding this comment.
- Wrong source, and we need Raw github URLs as sources
- Also, the images should be in the welcome directory replacing the layer5-celebration.png
- We recommend using uniform name conventions for images throughout our repos, Meshery-celebration-Dark.svg and Meshery-celebration-Light.svg
There are similar PRs opened regarding this change.
There was a problem hiding this comment.
in raw github urls shall i use "https://github.com/meshery/meshery-osm/tree/master/.github/welcome/Meshery-celebration-dark.svg"??
There was a problem hiding this comment.
Thanks @thisiskaransgit I overlooked this 😓 @Ghat0tkach proceed as guided
|
@ShivangShandilya @thisiskaransgit can you help me here? even after signing digitally and have verified digital signature its the github DCO is still failing |
There was a problem hiding this comment.
@Ghat0tkach, you would have to rebase the branch, click on the details option of DCO Check for instructions, also revert the changes in .gitignore file
.github/config.yml
Outdated
| <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/meshery/meshery-osm/master/.github/welcome/Meshery-celebration-dark.svg"> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/meshery/meshery-osm/master/.github/welcome/Meshery-celebration-light.svg"> |
There was a problem hiding this comment.
image names should be in lowercase
Signed-off-by: Vikram <awesomevikram3@gmail.com>
Signed-off-by: Vikram <awesomevikram3@gmail.com>
Signed-off-by: Vikramaditya Singh <59855919+Ghat0tkach@users.noreply.github.com> Signed-off-by: Vikram <awesomevikram3@gmail.com>
feat:added svg Signed-off-by: Vikramaditya Singh <59855919+Ghat0tkach@users.noreply.github.com> Signed-off-by: Vikram <awesomevikram3@gmail.com>
Signed-off-by: Vikram <awesomevikram3@gmail.com>
Signed-off-by: Vikram <awesomevikram3@gmail.com>
|
thank you @thisiskaransgit |
|
@Ghat0tkach revert the added line in the .gitignore file |
I have already removed the [alias] line in |
Signed-off-by: Vikramaditya Singh <59855919+Ghat0tkach@users.noreply.github.com>
|
@thisiskaransgit am i supposed to put |
|
@Ghat0tkach, you and I both overlooked it, please make the change, and thank you for pointing it out |
Signed-off-by: Vikramaditya Singh <59855919+Ghat0tkach@users.noreply.github.com>
|
Yup done @thisiskaransgit @ShivangShandilya . I did forgot to ask for reviews 😅 |
Couldnt be possible without your help and guidance @thisiskaransgit Thank you |
Fixed the hyperlinks for newcomers guide Signed-off-by: Vikramaditya Singh <59855919+Ghat0tkach@users.noreply.github.com>
Signed-off-by: Vikramaditya Singh <59855919+Ghat0tkach@users.noreply.github.com>
|
@anshgoyalevil please have a look , I forgot to tag you |
|
Thanks for your contribution to the Meshery! 🎉
|
Description
This PR fixes #235
Notes for Reviewers
Signed commits