Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

fix: migrate service from port 10010 to 10009 #45

Merged
merged 1 commit into from
Sep 7, 2020
Merged

fix: migrate service from port 10010 to 10009 #45

merged 1 commit into from
Sep 7, 2020

Conversation

kushthedude
Copy link
Contributor

Signed-off-by: Kush Trivedi kushthedude@gmail.com
fixed #44

Signed-off-by: Kush Trivedi <kushthedude@gmail.com>
@kumarabd
Copy link
Contributor

kumarabd commented Sep 6, 2020

@kushthedude we can't change this before changing port for smi tool. That is running on 10009

Copy link
Contributor

@kumarabd kumarabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smi-tool port needs to be changed first

@kushthedude
Copy link
Contributor Author

@kushthedude we can't change this before changing port for smi tool. That is running on 10009

The tool runs on 10008 port
https://github.com/layer5io/learn-layer5/blob/e6e57eccb62101378afebfb6166b31c34715bc8f/smi-conformance/main.go#L16

@leecalcote
Copy link
Member

leecalcote commented Sep 6, 2020

@leecalcote
Copy link
Member

10009 is currently reserved for Tanzu SM. Given that it's in an alpha state, we can swap these ports, if you feel this is a better fit.

We do need to get the Learn Layer5 port documented.

@kushthedude
Copy link
Contributor Author

kushthedude commented Sep 6, 2020 via email

@leecalcote
Copy link
Member

So are we expecting tanzu anytime soon?

Our roadmap has a few items in front of the Meshery Adapter for Tanzu Service Mesh, so no, it might be a couple months before we get to the adapter for Tanzu SM.

@kushthedude
Copy link
Contributor Author

I suggest let's migrate osm to 10009 then, @kumarabd ?

@leecalcote
Copy link
Member

Irrespective of this issue on OSM, let's move the SMI Conformance tool to either 10000 or to it's own unique, port.

Also, we will want the reservation for Tanzu SM updated - meshery/meshery-tanzu-sm#26

@kushthedude kushthedude merged commit 866f5bd into meshery:master Sep 7, 2020
@kushthedude kushthedude deleted the port branch September 7, 2020 11:58
@leecalcote
Copy link
Member

Please create an issue in the learn-layer5 repo to complete this reassignment.

@ghost
Copy link

ghost commented Sep 11, 2020

@kumarabd and @leecalcote where exactly is the learn-layer 5 repo? I need to see its port number so I can update the meshery docs with it

@kumarabd
Copy link
Contributor

@kumarabd and @leecalcote where exactly is the learn-layer 5 repo? I need to see its port number so I can update the meshery docs with it

@karenefereyan Here you go - https://github.com/layer5io/learn-layer5

@ghost
Copy link

ghost commented Sep 11, 2020

Thank you @kumarabd

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Move the meshery-osm adapter to port 10009
3 participants