Continue fleshing out bash completion script #12599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds bash completion to everything that I could think of except for the rewriter.
This will add highlighting when viewing on GitHub.
|
cc @lukester1975 if you could review, that would be great. |
|
@eli-schwartz could you cherry-pick the second commit to master? It doesn't need to be a part of this PR. |
|
Not sure I can really comment, what I did before was mainly just copying the existing code and filling in obvious gaps for existing options. I didn't get my head around the intricacies of bash completion in the slightest... That said, I've no idea why I didn't do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds bash completion to everything that I could think of except for the rewriter.