cmake: parse project version #12616
Merged
cmake: parse project version #12616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This properly sets the project version in projects meson generates from cmake projects. This allows dependency fallbacks to properly check the version constraints in dependency calls when falling back to a cmake subproject. Before this would fail, because the project version was undefined.
|
The lint error is a false positive: pylint-dev/pylint#9222 |
|
@kiwixz wanna give this a review as a resident CMake expert? |
kiwixz
approved these changes
Dec 13, 2023
|
It looks correct to me, but thanks for confirmation from people who know a lot more about the cmake internals we are using here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This properly sets the project version in projects meson generates from cmake projects. This allows dependency fallbacks to properly check the version constraints in dependency calls when falling back to a cmake subproject. Before this would fail, because the project version was undefined.
I modified an existing test for this, but feel free to suggest a different approach to testing this. I also am not experienced with any of this, so feedback is welcome!
Motivation was mostly that I had a lot of configure steps fail with the following error message (when trying out cmake fallbacks) and I'd rather not remove the version constraint: