Clean up testsuite intermediate files #13700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbaker
requested changes
Sep 21, 2024
run_meson_command_tests.py
Outdated
| @@ -212,6 +212,7 @@ def test_meson_runpython(self): | |||
| mesonout = self._run(python_command + [meson_command, 'runpython'] + cmd, env=env) | |||
| self.assertEqual(pyout, mesonout) | |||
|
|
|||
| os.remove(script_file) | |||
There was a problem hiding this comment.
To ensure this gets cleaned up even if there's a failure, add self.addCleanup(os.remove, scriptfile) right after the with open(...): block enstead. That cleanup happens regardless of how the function exits
The common test case "268 install functions and follow symlinks" requires that certain symlinks exist in order to function. If one clones a fresh repo and executes run_single_test.py with the aforementioned test as the target it will fail as the required symlinks are not part of the repo. Normally these symlinks are created and cleaned up when the overall testsuite is run but this is not the case for run_single_test.py This commit calls the necessary creation and cleanup functions in the case of run_single_test.py.
amcn
force-pushed
the
amcn/test_hygiene
branch
from
1ce7221
to
2352917
Compare
dcbaker
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running the testsuite locally for various in-flight things and I noticed that it can pollute the repo with intermediate files in some cases.
The changes in this PR address this such that running the suite no longer produces these intermediate files.