Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'section' key to buildoptions introspection #4546

Merged
merged 3 commits into from
Nov 26, 2018

Conversation

mensinda
Copy link
Member

This adds the new key section to each build option when running meson introspect --buildoptions. This allows IDEs to group the build options into the same sections as meson configure. This change should not break any existing code since only one key was added.

@textshell
Copy link
Contributor

We could use that for qtcreator-meson-plugin too. We recently added an options dialog and for now use a hardcoded list of sections and their options.

I'm curious on for what project do do want to use this? I'm trying to understand which projects use the introspection APIs to try to avoid breaking their use cases. Introspection is likely to need some extensions still for full IDE support.

'localedir',
'sysconfdir',
'localstatedir',
'sharedstatedir']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe sort these lists alphabetically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Fixed with the last commit.
I also sorted the lists in mconf.py since I have copied them from there.

@mensinda
Copy link
Member Author

@textshell I am working on the meson plugin for KDevelop, though it is in the early stages, so you don't have to worry about breaking anything currently.

@textshell
Copy link
Contributor

That's great. Let us know when there's anything public on that project. Also feel free to steal code from https://github.com/qtcreator-meson-plugin/qtcreator-meson-plugin/ if it seems useful.

I think currently there is still some things that are somewhat in need of definition on how a IDE integration with meson is expected to work. I'd love to chat about your ideas some time. Feel free to drop by in the #mesonbuild irc channel. I'm usually around in the evenings (MET).

@mensinda
Copy link
Member Author

Sure. Thanks for the offer.

@textshell
Copy link
Contributor

You also need to update the documentation and add an snippet for the release notes.

Also as this is a new feature it needs approval by @jpakkane

@mensinda
Copy link
Member Author

Done. I have also improved the IDE integration documentation.

@jpakkane jpakkane merged commit 2fb9814 into mesonbuild:master Nov 26, 2018
@mensinda mensinda deleted the buildopts branch November 26, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants