pcre2: increase the stack size for test builds #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jan200101
changed the title
|
upstream issue PCRE2Project/pcre2#65 |
|
You need to add a new release to the main json file. |
|
I figured this was not needed since I assumed the pcre2 branch was mainly for trying to get it updated |
eli-schwartz
reviewed
Jan 4, 2022
|
Adding a new release is not necessary -- because the primary release on that branch is not yet released, so bumping it to -2 means we'd have a -1 that was never released. And, thanks for looking into this! |
|
I'll rebase the pcre2 branch later today (and drop the debug commit) then merge this PR into it and release the combined update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the reason tests on Windows were failing was because the program was running out of stack space while expanding a regex operation.