Change LocalFileServer to allow respecting storm.yaml's nimbus.host #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this the only way to configure the URL that LocalFileServer listens to is via MESOS_NIMBUS_HOST environment variable. That differs from the behavior of the core MesosNimbus which supports that env variable, as well as the nimbus.host field in the storm.yaml config. So update the code to make them equally configurable.
|
@drewrobb : can you please review when you have a chance? Thanks! |
|
LGTM! |
|
looks like build is failing for unrelated reasons |
erikdw
force-pushed
the
make-LocalFileServer-respect-nimbus.host
branch
from
ad5fa4e
to
f2dd8f8
Compare
This is needed to allow the travis-ci builds to succeed.
It was failing with errors like this:
```
$ travis_retry sudo apt-get -o Dpkg::Options::="--force-confnew" install -y docker-engine=${TRAVIS_DOCKER_VERSION}
Reading package lists... Done
Building dependency tree
Reading state information... Done
Recommended packages:
yubico-piv-tool
The following packages will be DOWNGRADED:
docker-engine
0 upgraded, 0 newly installed, 1 downgraded, 0 to remove and 15 not upgraded.
Need to get 8,725 kB of archives.
After this operation, 58.0 MB disk space will be freed.
E: There are problems and -y was used without --force-yes
The command "sudo apt-get -o Dpkg::Options::=--force-confnew install -y docker-engine=1.10.3-0~trusty" failed. Retrying, 2 of 3.
```
erikdw
force-pushed
the
make-LocalFileServer-respect-nimbus.host
branch
from
f2dd8f8
to
bbaa442
Compare
|
@drewrobb : thanks for the review. Yeah, looks like the hardcoded |
|
@erikdw storm on mesos(0.28.2) cannot support zookeeper,so the mesos-master isn't HA! |
|
@zhanghangchina : this isn't the right place to make that comment @zhanghangchina. Please open an issue if you have a problem. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this the only way to configure the URL that LocalFileServer listens
to is via MESOS_NIMBUS_HOST environment variable. That differs from the
behavior of the core MesosNimbus which supports that env variable, as well
as the nimbus.host field in the storm.yaml config. So update the code to
make them equally configurable.