Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements to register framework user #195

Merged
merged 2 commits into from
Mar 7, 2017

Conversation

fuji-151a
Copy link
Contributor

I Implemented to be able to register framework user to run with Mesos.
Please check this pull request.

Thanks.

@erikdw
Copy link
Collaborator

erikdw commented Mar 7, 2017

@fuji-151a : have you tested that this works? I'm using mesos-1.0.1 and storm-1.0.2. When I set the mesos.framework.user to an alternate username, the MesosSupervisor is launched under that user, however the subsequent Worker processes are still owned by root.

I'm assuming we'd need to set some config in storm itself. Do you know what that is? We should update the docs if that's the case.

@erikdw
Copy link
Collaborator

erikdw commented Mar 7, 2017

Actually, I think I was wrong. It didn't make sense to me that a non-root process (MesosSupervisor) would be allowed to launch a root process (Worker). And upon further inspection, I think somehow I had some lingering processes from earlier runs and those misled me. So I believe this is working correctly... I'll play around a bit more before merging.

@erikdw
Copy link
Collaborator

erikdw commented Mar 7, 2017

Yup, this looks good to me, thanks for the contribution @fuji-151a !

@erikdw erikdw merged commit 6a53507 into mesos:master Mar 7, 2017
@fuji-151a fuji-151a deleted the register_framework_user branch March 9, 2017 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants