-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add server that provides k-apps contents #2680
Conversation
20b9727
to
b392a3d
Compare
b392a3d
to
bd7daa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this server be a thing in 2.14 (or if/when we have OCI support) ? If not, wdyt of using just a simple container image that has the necessary artifacts at a certain known path. pulling it as init container will be enough. I am not against the idea of server but this seems like an overkill for a soon to be dead code (and for something that is very short lived - bootstrap job takes less than 10m in happy path).
Yes, I get it, the choice is between having a server and relying on a git operator way of initializing the repository (that won't change when we move to OCI) or having an init container and creating a custom way of initializing the repository that will go away when we move to the OCI. I would favor the former. In other words, this web server fits in the APIs and git operator not the other way around. |
So in the current way, we would have to:
But, if we can publish a docker image (that is very close a future oci image, basically a simple image that has some file system) then we can keep the future refactoring minimal by
|
bd7daa5
to
000750a
Compare
Pull Request Test Coverage Report for Build 11167419015Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
We discussed it on Slack but for someone reading it: both are already happening actually. The oci artifact is already being published since 2.12. Git operator is being able to consume OCI artifact when initializing a repository. In other words: this method is reducing the future refactoring to the absolute minimum. |
This reverts commit 3fb17c9.
What problem does this PR solve?:
Produce a docker image with http server.
Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-102822
Special notes for your reviewer:
To move things quickly, I'm using github.com/sigoden/dufs. I use it because it supports tls but I'm planning to create our own (maybe a few lines in Python - let's see what's the fastest).
Does this PR introduce a user-facing change?:
Checklist