MBS-12942: Also indicate if target has pending edits in relationship editor #2901
Conversation
|
@brainzbot, retest this please |
|
Nice!! |
|
Hmm. The height of both those icons is supposed to be 16px right now... |
|
huh, maybe the other icons have whitespace around them? It’s only a few px but it makes a difference: |
|
@Aerozol: can you play with it a bit and see what the preferred height would be for you? 15? 14? |
|
Apologies if you've already discussed this, but is there any way we can convey the meaning of this icon a bit better? I tried adding the following but you can't really make it out at 16px:
|
|
Hovering will open a tooltip anyway, so I don't think it's the end of the world if we cannot make it more obvious than it is now at that size :) |
|
Lost this ticket in my emails, sorry tīmu! re. sizing, I had a look and the other icons do have whitespace around them in the png file. Let’s just do full size (e.g. the same size as the others), we’ll replace those icons at some point anyway. |
|
Updated this with the new icons :) |
Aerozol made us this, we should use it.
We were already showing if the relationship itself has pending edits, but not if the target entity has them (which the old relationship editor used to indicate with a highlight). Aerozol made us a nice icon to use for this, and I think it's quite useful to have it and link to the entity's open edits page.
Implement MBS-12942
Problem
The old relationship editor highlighted entities with pending edits, but the new one does not. We now indicate relationships with pending edits with an icon, but there's nothing indicating an entity has pending edits.
Solution
@Aerozol came up with a pair of icons to represent entity and relationship pending edits, so I added a second tooltip option for when the entity has pending edits. See images below. This one links to the
/open_editspage for the entity.Testing
By hand on a fake release I changed so that it has both types of pending edits.
Example
On top of #2964 to use the other icons in the new set already.