Empty volume folders when downloading cbz files

[Johndirr]

Describe the bug

When downloading with MANGAL_FORMATS_USE = cbz and MANGAL_DOWNLOADER_CREATE_VOLUME_DIR = true, an empty folder for each volume will be created in the mangal directory:

The cbz files are still created chapter-wise and are correctly placed in the folder of the manga.

Reproduction steps

1. Set MANGAL_FORMATS_USE = cbz and MANGAL_DOWNLOADER_CREATE_VOLUME_DIR = true
2. Download a Manga with information about their volumes (e.g. from Mangadex)

Expected behavior

For each volume a cbz gets created.

Additional context

Using mangal_4.0.6_Windows_x86_64

Operating System

Windows

[shinji257]

I have not been able to get it to create any directories. Just for the heck of it I did add the volume template tag to the filenames and it does have something there so I don't know why it isn't making them at all. Currently running latest git code but I don't think it was working at all for the last release version either.

EDIT: Nevermind. They are created. It is that they are being created in the current running directory and not where you set downloader.path to.

EDIT: These are suspect lines but I don't know how to get what is in err or if there is even anything there. If error != nil then it defaults the download location to . for some reason.

mangal/where/where.go

Lines 66 to 77 in 165f7ca

	func Downloads() string {
	path, err := filepath.Abs(viper.GetString(key.DownloaderPath))
	if err != nil {
	path, err = os.Getwd()
	if err != nil {
	path = "."
	}
	}
	return mkdir(path)
	}

The volume name is then appended here and created for the download. However I think it is actually getting back . from the Downloads function as it makes sense given that right now it seems to be doing effectively ./{volume} for folder creation.

mangal/source/manga.go

Lines 103 to 111 in 165f7ca

	func (m *Manga) peekPath() string {
	path := where.Downloads()
	if viper.GetBool(key.DownloaderCreateMangaDir) {
	path = filepath.Join(path, m.Dirname())
	}
	return path
	}