Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bash and curl update from docker image. #139

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Remove bash and curl update from docker image. #139

merged 2 commits into from
Jan 15, 2021

Conversation

Gerrit91
Copy link
Contributor

@Gerrit91 Gerrit91 commented Dec 8, 2020

Looks like we can just remove these lines? I think this was used for controller generation at some point in time, but I can't find any references to curl anymore.

@Gerrit91 Gerrit91 marked this pull request as draft December 8, 2020 11:29
@Gerrit91 Gerrit91 marked this pull request as ready for review December 8, 2020 11:55
Gerrit91 referenced this pull request Dec 8, 2020
* call go mod vendor from Makefile
* use code-generator from go.mod
* update to golang:1.15 AS builder
* update to alpine:3.12
* update dependencies
Copy link

@hardikdr hardikdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks.

@Gerrit91 Gerrit91 requested a review from majst01 January 15, 2021 13:35
@Gerrit91 Gerrit91 merged commit 0bcfe19 into master Jan 15, 2021
@Gerrit91 Gerrit91 deleted the cleanup branch January 15, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants