-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor firewall reconcile. #71
Conversation
Gerrit91
commented
Jun 15, 2020
•
edited
Loading
edited
- Adapts to latest controller implementations of other extension providers (controller-library was not yet introduced, will be done for Gardener >=v1.5 controller)
- Smaller functions for firewall reconcile
- Compares firewall image properly and recreates firewall if image changed on shoot spec (respects semantic versioning)
- Fixes a possible issue where a firewall could be deleted even if it does not belong to the cluster anymore
117c902
to
19016c0
Compare
19016c0
to
87fd01c
Compare
e36020f
to
6e39cbe
Compare
1e86d0c
to
69c8518
Compare
I tried it out and it is working nicely. We can now do these kind of things as well:
And it will result into:
|
@@ -28,7 +28,7 @@ require ( | |||
github.com/grpc-ecosystem/go-grpc-middleware v1.1.0 // indirect | |||
github.com/jetstack/cert-manager v0.6.2 // indirect | |||
github.com/metal-stack/firewall-controller v0.1.0 | |||
github.com/metal-stack/metal-go v0.3.2 | |||
github.com/metal-stack/metal-go v0.7.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to the most recent version. Also here, we still refer to a ancient mcm:
github.com/gardener/machine-controller-manager => github.com/metal-pod/machine-controller-manager v0.0.0-20190801141331-4e2b75ebc6c0
This must be fixed as well