Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build for go 1.15 #85

Merged
merged 1 commit into from
Aug 26, 2020
Merged

fix build for go 1.15 #85

merged 1 commit into from
Aug 26, 2020

Conversation

mwennrich
Copy link
Contributor

  • call go mod vendor from Makefile
  • use code-generator from go.mod
  • update to golang:1.15 AS builder
  • update to alpine:3.12
  • update dependencies

@Gerrit91
Copy link
Contributor

This looks promising. But the Makefile target generate-in-docker, that we require every now and then, does not work for me:

$ make generate-in-docker 
...
Generate
cp: cannot create regular file '../../../hack/../vendor/k8s.io/code-generator/': No such file or directory
bash: ../../../hack/../vendor/k8s.io/code-generator/generate-internal-groups.sh: No such file or directory
bash: ../../../hack/../vendor/k8s.io/code-generator/generate-internal-groups.sh: No such file or directory
bash: ../../../hack/../vendor/k8s.io/code-generator/generate-internal-groups.sh: No such file or directory
bash: ../../../hack/../vendor/k8s.io/code-generator/generate-internal-groups.sh: No such file or directory
pkg/apis/metal/doc.go:18: running "../../../hack/generate-code": exit status 127
Successfully generated controller registration at ../../example/controller-registration.yaml
...

* call go mod vendor from Makefile
* use code-generator from go.mod
* update to golang:1.15 AS builder
* update to alpine:3.12
* update dependencies
@Gerrit91 Gerrit91 merged commit 7064148 into master Aug 26, 2020
@Gerrit91 Gerrit91 deleted the fix-go-1.15-build branch August 26, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants