Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for UEFI HTTP boot #459

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Add support for UEFI HTTP boot #459

merged 1 commit into from
Aug 23, 2024

Conversation

elfosardo
Copy link
Member

@elfosardo elfosardo commented Jul 8, 2024 •
edited
Loading

Proposal to add support for UEFI HTTP boot adding a new hardware driver redfish-uefihttp that uses the already implemented ironic redfish-https boot interface.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2024
@elfosardo elfosardo force-pushed the uefi-http-boot branch 2 times, most recently from b9f4584 to 81ab364 Compare July 8, 2024 17:32
@elfosardo
Copy link
Member Author

/cc @dtantsur

@elfosardo elfosardo mentioned this pull request Jul 10, 2024
Open
@elfosardo elfosardo force-pushed the uefi-http-boot branch 3 times, most recently from 61f2ea2 to bceff1b Compare July 15, 2024 15:25
@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2024
Rozzii
Rozzii reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine this feature would be a nice addition, I am a bit unclear on the config drive limitations as per my comment.

design/baremetal-operator/uefi-http-boot.md Outdated Show resolved Hide resolved
@elfosardo elfosardo force-pushed the uefi-http-boot branch 2 times, most recently from 521dc43 to b700091 Compare August 5, 2024 07:32
@tuminoid
Copy link
Member

tuminoid commented Aug 5, 2024

Generally looks fine this feature would be a nice addition, I am a bit unclear on the config drive limitations as per my comment.

Holding for this, feel free to clear when cleared.
/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2024
Rozzii
Rozzii reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

It looks okay to me, I won't remove the "hold" because there might be further discussion by others.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2024
@elfosardo
Add support for UEFI HTTP boot
54252d1 
Proposal to add support for UEFI HTTP boot adding a new hardware
driver `redfish-http-boot` that uses the already implemented
ironic `redfish-https` boot interface.

Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2024
@elfosardo
Copy link
Member Author

thanks @MahnoorAsghar , I've fixed the nits

@MahnoorAsghar
Copy link

LGTM :)

@elfosardo
Copy link
Member Author

/unhold
a week has passed

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2024
Rozzii
Rozzii reviewed Aug 23, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2024
@metal3-io-bot metal3-io-bot merged commit 3784a49 into metal3-io:main Aug 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur left review comments

@Rozzii Rozzii Rozzii left review comments

@MahnoorAsghar MahnoorAsghar MahnoorAsghar left review comments

@kashifest kashifest Awaiting requested review from kashifest

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@elfosardo @dtantsur @metal3-io-bot @tuminoid @MahnoorAsghar @Rozzii