Skip to content
This repository has been archived by the owner on Aug 14, 2022. It is now read-only.

Using telebot v2 #45

Closed
wants to merge 6 commits into from
Closed

Conversation

lovung
Copy link

@lovung lovung commented Jan 17, 2019

No description provided.

Copy link
Owner

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time for preparing this contribution.
Sorry, if this now sounds harsh, but most of the changes in here are totally unrelated to updating telebot to v2. Some files simply don't belong in the repository at all, like .docx files.
I stopped reviewing the files at some point, so only in the first half there are comments. Please address these before I take another look.

Dockerfile Show resolved Hide resolved
Gopkg.lock Show resolved Hide resolved
Makefile Show resolved Hide resolved
"github.com/oklog/run"
"github.com/prometheus/alertmanager/notify"
"github.com/prometheus/alertmanager/template"
"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/promhttp"
"gopkg.in/alecthomas/kingpin.v2"
"github.com/vu-long/alertmanager-bot/pkg/alertmanager"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to clone this project into $GOPATH/src/github.com/metalmatze/alertmanager-bot and not update these import paths.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add me as a contributor, it let me push my branch to your repos.

@@ -0,0 +1,144 @@
version: "3"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to merge this example at all, please open another Pull Request for doing so.

docs/Assignment.md Show resolved Hide resolved
docs/DatabaseDesign.md Show resolved Hide resolved
docs/Reference.md Show resolved Hide resolved
docs/SystemDiagram.xml Show resolved Hide resolved
@lovung
Copy link
Author

lovung commented Jan 17, 2019

@metalmatze OK let me do other PR for telebot v2.

@lovung lovung closed this Jan 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants