-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review #6
Review #6
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,396 @@ | ||
'use strict'; | ||
|
||
const common = require('metarhia-common'); | ||
|
||
const Stream = require('stream'); | ||
|
||
const Writable = function(options) { | ||
if (!(this instanceof Writable)) return new Writable(options); | ||
Stream.Writable.call(this, options); | ||
|
||
delete this._writableState.bufferedRequest; | ||
delete this._writableState.bufferedRequestCount; | ||
delete this._writableState.lastBufferedRequest; | ||
delete this._writableState.corkedRequestsFree; | ||
|
||
this._writableState.bufferedArray = null; | ||
this._writableState.bufferedSize = 0; | ||
|
||
this._writableState.onwrite = onwrite.bind(undefined, this); | ||
}; | ||
|
||
common.inherits(Writable, Stream.Writable); | ||
|
||
Writable.prototype.write = function(chunk, encoding, callback) { | ||
const state = this._writableState; | ||
const isBuffer = !state.objectMode && Stream._isUint8Array(chunk); | ||
|
||
if (isBuffer && Object.getPrototypeOf(chunk) !== Buffer.prototype) { | ||
chunk = Stream._uint8ArrayToBuffer(chunk); | ||
} | ||
|
||
if (typeof encoding === 'function') { | ||
callback = encoding; | ||
encoding = null; | ||
} | ||
|
||
if (isBuffer) { | ||
encoding = 'buffer'; | ||
} else if (!encoding) { | ||
encoding = state.defaultEncoding; | ||
} | ||
|
||
if (typeof callback !== 'function') { | ||
callback = function() {}; | ||
} | ||
|
||
if (state.ending) { | ||
writeAfterEnd(this, callback); | ||
return false; | ||
} | ||
|
||
if (isBuffer || isChunkValid(this, state, chunk, callback)) { | ||
state.pendingcb++; | ||
return writeOrBuffer(this, state, isBuffer, chunk, encoding, callback); | ||
} | ||
|
||
return false; | ||
}; | ||
|
||
Writable.prototype.end = function(chunk, encoding, callback) { | ||
const state = this._writableState; | ||
|
||
if (typeof chunk === 'function') { | ||
callback = chunk; | ||
chunk = null; | ||
encoding = null; | ||
} else if (typeof encoding === 'function') { | ||
callback = encoding; | ||
encoding = null; | ||
} | ||
|
||
if (chunk !== null && chunk !== undefined) | ||
this.write(chunk, encoding); | ||
|
||
if (state.corked) { | ||
state.corked = 1; | ||
this.uncork(); | ||
} | ||
|
||
if (!state.ending) { | ||
endWritable(this, state, callback); | ||
} | ||
|
||
return this; | ||
}; | ||
|
||
Writable.prototype.cork = function() { | ||
this._writableState.corked++; | ||
}; | ||
|
||
Writable.prototype.uncork = function() { | ||
const state = this._writableState; | ||
|
||
if (state.corked) { | ||
state.corked--; | ||
|
||
if ( | ||
!state.writing && | ||
!state.corked && | ||
!state.bufferProcessing && | ||
state.bufferedArray && | ||
Array.isArray(state.bufferedArray) && | ||
state.bufferedSize | ||
) { | ||
clearBuffer(this, state); | ||
} | ||
} | ||
}; | ||
|
||
Writable.prototype.pipe = function() { | ||
this.emit('error', new Error('Cannot pipe, not readable')); | ||
}; | ||
|
||
// internal functions | ||
|
||
const writeAfterEnd = (stream, callback) => { | ||
const error = new Error('write after end'); | ||
|
||
stream.emit('error', error); | ||
process.nextTick(callback, error); | ||
}; | ||
|
||
function isChunkValid(stream, state, chunk, callback) { | ||
let error; | ||
|
||
if (chunk === null) { | ||
error = new Error('May not write null values to stream'); | ||
} else if (typeof chunk !== 'string' && !state.objectMode) { | ||
error = new Error('Chunk must be an instance of Buffer or string'); | ||
} | ||
|
||
if (error) { | ||
stream.emit('error', error); | ||
process.nextTick(callback, error); | ||
return false; | ||
} | ||
|
||
return true; | ||
}; | ||
|
||
const writeOrBuffer = (stream, state, isBuffer, chunk, encoding, callback) => { | ||
if (!isBuffer) { | ||
const newChunk = decodeChunk(state, chunk, encoding); | ||
|
||
if (chunk !== newChunk) { | ||
isBuffer = true; | ||
encoding = 'buffer'; | ||
chunk = newChunk; | ||
} | ||
} | ||
|
||
const length = state.objectMode ? 1 : chunk.length; | ||
state.length += length; | ||
|
||
let ret = state.length < state.highWaterMark; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
if (!ret) { | ||
state.needDrain = true; | ||
} | ||
|
||
if (state.writing || state.corked) { | ||
if (state.bufferedArray && Array.isArray(state.bufferedArray) && state.bufferedSize) { | ||
state.bufferedArray.push({ | ||
chunk, | ||
encoding, | ||
isBuffer, | ||
callback, | ||
}); | ||
} else { | ||
state.bufferedArray = [{ | ||
chunk, | ||
encoding, | ||
isBuffer, | ||
callback, | ||
}]; | ||
} | ||
state.bufferedSize += 1; | ||
} else { | ||
doWrite(stream, state, false, length, chunk, encoding, callback); | ||
} | ||
|
||
return ret; | ||
}; | ||
|
||
const doWrite = (stream, state, writev, length, chunk, encoding, callback) => { | ||
state.writelen = length; | ||
state.writecb = callback; | ||
state.writing = true; | ||
state.sync = true; | ||
|
||
if (state.destroyed) { | ||
state.onwrite(new Error('Cannot call write after a stream was destroyed')); | ||
} else if (writev) { | ||
stream._writev(chunk, state.onwrite); | ||
} else { | ||
stream._write(chunk, encoding, state.onwrite); | ||
} | ||
|
||
state.sync = false; | ||
}; | ||
|
||
const onwrite = (stream, error) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is necessary to change all lambda functions to a functional declaration, or to raise lambdas to the top, since they are called above There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd prefer reorder and use lambdas in all cases where |
||
const state = stream._writableState; | ||
const sync = state.sync; | ||
const callback = state.writecb; | ||
|
||
if (typeof callback !== 'function') { | ||
throw new Error('Callback called multiple times'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @tshemsedinov Maybe we should not throw mistakes like this. For example, we can take all the error messages in constants, or at least create variables with them somewhere, and then turn to them? Or is it normal? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For this certain purpose we have |
||
} | ||
|
||
onwriteStateUpdate(state); | ||
|
||
if (error) { | ||
onwriteError(stream, state, sync, error, callback); | ||
} else { | ||
const finished = needFinish(state); | ||
|
||
if ( | ||
!finished && | ||
!state.corked && | ||
!state.bufferProcessing && | ||
state.bufferedArray && | ||
Array.isArray(state.bufferedArray) && | ||
state.bufferedSize | ||
) { | ||
clearBuffer(stream, state); | ||
} | ||
|
||
if (sync) { | ||
process.nextTick(afterWrite, stream, state, finished, callback); | ||
} else { | ||
afterWrite(stream, state, finished, callback); | ||
} | ||
} | ||
}; | ||
|
||
const onwriteError = (stream, state, sync, error, callback) => { | ||
--state.pendingcb; | ||
|
||
if (sync) { | ||
process.nextTick(callback, error); | ||
process.nextTick(finishMaybe, stream, state); | ||
stream._writableState.errorEmitted = true; | ||
stream.emit('error', error); | ||
} else { | ||
callback(error); | ||
stream._writableState.errorEmitted = true; | ||
stream.emit('error', error); | ||
finishMaybe(stream, state); | ||
} | ||
}; | ||
|
||
function onwriteStateUpdate(state) { | ||
state.writing = false; | ||
state.writecb = null; | ||
state.length -= state.writelen; | ||
state.writelen = 0; | ||
}; | ||
|
||
const afterWrite = (stream, state, finished, callback) => { | ||
if (!finished) { | ||
onwriteDrain(stream, state); | ||
} | ||
|
||
state.pendingcb--; | ||
callback(); | ||
finishMaybe(stream, state); | ||
}; | ||
|
||
const onwriteDrain = (stream, state) => { | ||
if (state.length === 0 && state.needDrain) { | ||
state.needDrain = false; | ||
stream.emit('drain'); | ||
} | ||
}; | ||
|
||
const clearBuffer = (stream, state) => { | ||
state.bufferProcessing = true; | ||
|
||
if (state.bufferedArray && Array.isArray(state.bufferedArray) && state.bufferedSize) { | ||
if (stream._writev) { | ||
const callbacks = state.bufferedArray.map(entry => entry.callback); | ||
|
||
doWrite( | ||
stream, | ||
state, | ||
true, | ||
state.length, | ||
state.bufferedArray, | ||
'', | ||
(error, data) => { | ||
callbacks.forEach((cb) => { | ||
state.pendingcb--; | ||
cb(error, data); | ||
}); | ||
} | ||
); | ||
state.pendingcb++; | ||
state.bufferedArray = null; | ||
state.bufferedSize = 0; | ||
} else { | ||
for (const entry of state.bufferedArray) { | ||
const chunk = entry.chunk; | ||
const encoding = entry.encoding; | ||
const callback = entry.callback; | ||
const length = state.objectMode ? 1 : chunk.length; | ||
doWrite(stream, state, false, length, chunk, encoding, callback); | ||
state.bufferedSize--; | ||
if (state.writing) { | ||
break; | ||
} | ||
}; | ||
} | ||
} | ||
|
||
state.bufferedArray = null; | ||
state.bufferProcessing = false; | ||
}; | ||
|
||
const needFinish = (state) => ( | ||
state.ending && | ||
state.length === 0 && | ||
state.bufferedArray === null && | ||
!state.finished && | ||
!state.writing | ||
); | ||
|
||
const callFinal = (stream, state) => { | ||
stream._final((error) => { | ||
state.pendingcb--; | ||
|
||
if (error) { | ||
stream.emit('error', error); | ||
} | ||
|
||
state.prefinished = true; | ||
stream.emit('prefinish'); | ||
finishMaybe(stream, state); | ||
}); | ||
}; | ||
|
||
const prefinish = (stream, state) => { | ||
if (!state.prefinished && !state.finalCalled) { | ||
if (typeof stream._final === 'function' && !state.destroyed) { | ||
state.pendingcb++; | ||
state.finalCalled = true; | ||
process.nextTick(callFinal, stream, state); | ||
} else { | ||
state.prefinished = true; | ||
stream.emit('prefinish'); | ||
} | ||
} | ||
}; | ||
|
||
const finishMaybe = (stream, state) => { | ||
const need = needFinish(state); | ||
|
||
if (need) { | ||
prefinish(stream, state); | ||
if (state.pendingcb === 0) { | ||
state.finished = true; | ||
stream.emit('finish'); | ||
} | ||
} | ||
|
||
return need; | ||
}; | ||
|
||
const endWritable = (stream, state, callback) => { | ||
state.ending = true; | ||
finishMaybe(stream, state); | ||
|
||
if (callback) { | ||
if (state.finished) { | ||
process.nextTick(callback); | ||
} | ||
else { | ||
stream.once('finish', callback); | ||
} | ||
} | ||
|
||
state.ended = true; | ||
stream.writable = false; | ||
}; | ||
|
||
const decodeChunk = (state, chunk, encoding) => { | ||
if (!state.objectMode && | ||
state.decodeStrings !== false && | ||
typeof chunk === 'string') { | ||
chunk = Buffer.from(chunk, encoding); | ||
} | ||
|
||
return chunk; | ||
}; | ||
|
||
module.exports = Writable; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be better
onwrite.bind(null, this);