Protobuf version guessing v2 #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilsche
force-pushed
the
fix-protobuf-version
branch
from
815b70a
to
06ad67a
Compare
During the build process, protoc is invoked to build protobuf files. These built files are deployed to users, and thus the users require a compatible python-protobuf version. For that, the required protobuf version is set during the build process in setup.py. However, this version selection is not up to date with the versioning scheme used by protobuf. protobuf keeps the major version independent between languages, and minor/patch versions in sync. E.g., as of the time of writing, python-protobuf 4.21.12 is compatible with libprotoc 3.21.12. see: https://protobuf.dev/news/2022-05-06/ However, it is not clear under which circumstances these versions are compatible to each other. (I.e., even if minor/patch version are different, the binary format may still be compatible.) This makes correctly predicting the required (potentially unrealeased) python-protobuf version impossible. Co-authored-by: Hannes T <80697868+s9105947@users.noreply.github.com>
We don't know a specific minimum requirement, this is just eyeballing it. Versions of protoc below 3 definitely won't match with the protobuf versioning scheme that reset the minor version at 3.0.0.
Only ignore parts of setup.py. This has two advantages: 1) If isort is applied to the file directly, e.g., by an eager IDE, it still doesn't sort the setuptools imports as needed. 2) The rest of the imports is sorted. Also remove the configured ignore for docs/conf.py which seems to be fine.
tilsche
force-pushed
the
fix-protobuf-version
branch
from
06ad67a
to
8b01b34
Compare
bmario
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #140