official composer CA bundle support #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fprochazka
reviewed
Nov 22, 2016
| @@ -28,7 +28,8 @@ | |||
| "satooshi/php-coveralls": "^1.0" | |||
| }, | |||
| "suggest": { | |||
| "kdyby/curl-ca-bundle": "Provides regularly updated root certificates list" | |||
| "kdyby/curl-ca-bundle": "Provides regularly updated root certificates list", | |||
There was a problem hiding this comment.
Would be better to remove the suggest altogether :)
There was a problem hiding this comment.
Původně jsem chtěl, ale ty tam nemáš abandoned, tak jsem to ještě nechal.
There was a problem hiding this comment.
There was a problem hiding this comment.
Divný, koukal jsem sem - https://github.com/Kdyby/CurlCaBundle/blob/master/composer.json
There was a problem hiding this comment.
Tak a je fuč :) V kódu jsem to teda ještě nechal, ať se něco nerozbije.
There was a problem hiding this comment.
Oni na to mají UI, nemusíš to psát do composer.json
mhujer
requested changes
Nov 22, 2016
| @@ -39,7 +39,9 @@ public function getCertificatePath() | |||
| return $this->certificatePath; | |||
| } | |||
|
|
|||
| if (class_exists('\Kdyby\CurlCaBundle\CertificateHelper')) { | |||
| if(class_exists('\Composer\CaBundle\CaBundle')) { | |||
| if (class_exists('\Kdyby\CurlCaBundle\CertificateHelper')) { | ||
| if(class_exists('\Composer\CaBundle\CaBundle')) { | ||
| return \Composer\CaBundle\CaBundle::getSystemCaRootBundlePath(); | ||
| } elseif(class_exists('\Kdyby\CurlCaBundle\CertificateHelper')) { |
|
merged manually (I've fixed-up the cs fix), thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.