Skip to content

Commit

Permalink
process: maintain constructor descriptor
Browse files Browse the repository at this point in the history
Use the original property descriptor instead of just taking the value,
which would, by default, be non-writable and non-configurable.

PR-URL: nodejs/node#9306
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
bengl authored and andrew749 committed Jul 19, 2017
1 parent 212986c commit 471a85d
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 3 deletions.
5 changes: 2 additions & 3 deletions lib/internal/bootstrap_node.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,9 @@
const EventEmitter = NativeModule.require('events');
process._eventsCount = 0;

const origProcProto = Object.getPrototypeOf(process);
Object.setPrototypeOf(process, Object.create(EventEmitter.prototype, {
constructor: {
value: process.constructor
}
constructor: Object.getOwnPropertyDescriptor(origProcProto, 'constructor')
}));

EventEmitter.call(process);
Expand Down
15 changes: 15 additions & 0 deletions test/parallel/test-process-prototype.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
'use strict';
require('../common');
const assert = require('assert');
const EventEmitter = require('events');

const proto = Object.getPrototypeOf(process);

assert(proto instanceof EventEmitter);

const desc = Object.getOwnPropertyDescriptor(proto, 'constructor');

assert.strictEqual(desc.value, process.constructor);
assert.strictEqual(desc.writable, true);
assert.strictEqual(desc.enumerable, false);
assert.strictEqual(desc.configurable, true);

0 comments on commit 471a85d

Please sign in to comment.