Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone issue when multiple dt-* #147

Closed
gRegorLove opened this issue Mar 11, 2018 · 1 comment
Closed

Timezone issue when multiple dt-* #147

gRegorLove opened this issue Mar 11, 2018 · 1 comment

Comments

@gRegorLove
Copy link
Member

@kartikprabhu pointed this out with his VCP testing: When multiple date parts, the normalized timezone is being appended multiple times, resulting in the incorrect value 2014-06-01 12:30-0600-0600-0600

 <div class="h-event">
   <h1 class="p-name">Multiple date and time values</h1>

   <p> When:
     <span class="dt-start">
       <span class="value" title="June 1, 2014">2014-06-01</span>
       <span class="value" title="June 1, 3014">3014-06-01</span>
       <span class="value" title="12:30">12:30</span>
       (UTC<span class="value">-06:00</span>)
       <span class="value" title="23:00">23:00</span>
       (UTC<span class="value">+01:00</span>)
       –
       <span class="dt-end">19:30</span>
   </p>

 </div>

parsed result from current master branch:

{
    "items": [
        {
            "type": [
                "h-event"
            ],
            "properties": {
                "name": [
                    "Multiple date and time values"
                ],
                "start": [
                    "2014-06-01 12:30-0600-0600-0600"
                ],
                "end": [
                    "2014-06-01 19:30-0600"
                ]
            }
        }
    ],
    "rels": {},
    "rel-urls": {},
    "debug": {
        "package": "https://packagist.org/packages/mf2/mf2",
        "version": "dev-master",
        "note": [
            "This output was generated from the php-mf2 library available at https://github.com/indieweb/php-mf2",
            "Please file any issues with the parser at https://github.com/indieweb/php-mf2/issues"
        ]
    }
}
gRegorLove added a commit to gRegorLove/php-mf2 that referenced this issue Mar 11, 2018
aaronpk added a commit that referenced this issue Mar 11, 2018
@aaronpk
Copy link
Member

aaronpk commented Mar 11, 2018

Fixed in #148

@aaronpk aaronpk closed this as completed Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants