remove view from mysql backend #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilpatds
approved these changes
Nov 30, 2022
leojh
reviewed
Dec 8, 2022
The view_queue is not materialized, and thus functions as syntactic sugar for a complex query. Furthermore, our infrastructure works poorly with views. Therefore, this usage adds a significant maintainership burden for little gain. This commit removes the view from NanoMDM code paths, but it still exists in the schema. This is purely for convenience and interactive users. Furthermore, I added an index used by the queue query, which should have existed for the view. This should improve performance. Testing: * Tested migration - see the schema migration script * Tested base functionality * Passes new integration test
jessepeterson
approved these changes
Feb 27, 2023
| ON r.command_uuid = q.command_uuid AND r.id = q.id | ||
| WHERE q.id = ? | ||
| AND q.active = 1 | ||
| AND (r.status IS NULL OR (r.status = 'NotNow' AND NOT ?)) |
There was a problem hiding this comment.
Clever! I hadn't thought about using a bool value as a query param.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The view_queue is not materialized, and thus functions as syntactic
sugar for a complex query. Furthermore, our infrastructure works poorly
with views. Therefore, this usage adds a significant maintainership
burden for little gain.
This commit removes the view from NanoMDM code paths, but it still
exists in the schema. This is purely for convenience and interactive
users.
Furthermore, I added an index used by the queue query, which should have
existed for the view. This should improve performance.
Testing:
depends on #58
fixes #53 for mysql backend