Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for KafkaStreamsMetrics (similar to KafkaConsumerMetrics) #1096

Closed
OleksiiBondar opened this issue Dec 23, 2018 · 1 comment · Fixed by #1835
Closed

Add support for KafkaStreamsMetrics (similar to KafkaConsumerMetrics) #1096

OleksiiBondar opened this issue Dec 23, 2018 · 1 comment · Fixed by #1835
Labels
enhancement A general enhancement
Milestone
1.4.0

Comments

@OleksiiBondar
Copy link
Contributor

OleksiiBondar commented Dec 23, 2018 •
edited by izeye
Loading

It would be great to publish Kafka streams metrics which already available through JMX beans.
List of available attributes - https://kafka.apache.org/documentation/#kafka_streams_monitoring
https://www.madewithtea.com/monitoring-kafka-streams-metrics-via-jmx.html
@jkschneider jkschneider mentioned this issue Jan 2, 2019
Closed
@OleksiiBondar OleksiiBondar mentioned this issue Jan 22, 2019
Closed
@jkschneider jkschneider added this to the 1.2.0 milestone Feb 28, 2019
@shakuzen shakuzen added the enhancement A general enhancement label Jun 17, 2019
@shakuzen shakuzen modified the milestones: 1.2.0 (non-LTS), 1.3.0 Jun 28, 2019
@shakuzen shakuzen modified the milestones: 1.3.0, 1.4.0 Oct 1, 2019
@jeqo jeqo mentioned this issue Mar 10, 2020
Merged
shakuzen pushed a commit that referenced this issue Mar 10, 2020
@jeqo
Kafka meter binder without JMX (#1835)
abc0b30 
Provides a replacement for the `KafkaConsumerMetrics` binder (uses JMX) - `KafkaClientMetrics` and `KafkaStreamsMetrics` binders based off metrics provided by the Kafka client API. This allows all metrics provided by the client to be registered as Micrometer metrics, with the caveat that metrics with the same name but less tags will not be registered. For some metrics, Kafka provides a total metric and one broken down by things like topic and partition. Micrometer will opt to register the most specific ones.

Resolves #1095
Resolves #1096
@shakuzen
Copy link
Member

Thank you everyone for the interest in this. This has been implemented by #1835 as an incubating feature in 1.4 (see the KafkaStreamsMetrics binder). Please try it out (available in snapshots now, soon to be released) and give feedback. With enough feedback, we can promote this to a non-incubating feature.

@sobychacko sobychacko mentioned this issue Mar 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Kafka binder without JMX jeqo/micrometer
3 participants
@jkschneider @OleksiiBondar @shakuzen