Dont create stackdriver metrics if they already exists #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contributions. Would it be possible to separate out the changes to separate pull requests? It would be easier to review and merge them individually, and that way ensures review of one change does not block others. Also, for auditing purposes, it is nice to be able to refer to a distinct pull request or issue when referencing a change in release notes or a related issue. Thanks again! |
shakuzen
reviewed
Dec 12, 2019
...r-registry-stackdriver/src/main/java/io/micrometer/stackdriver/StackdriverMeterRegistry.java
Outdated
Show resolved
Hide resolved
|
Hi Tommy(@shakuzen ) As requested I splitted the original PR up in 3, this one and 1750 and 1751, hope that is the way you meant it? |
Yes, thank you. I'll take a look at them. |
shakuzen
changed the title
ramondebeijer
force-pushed
the
stackdriver-approvements
branch
from
654a587
to
49f2059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about checking which metrics are already there at "startup" instead of trying to create them once and them remember them.
Originally this PR also contained 2 other fixes but they are moved to seperate PR's