Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Stackdriver resource labels #1818

Conversation

jmccance
Copy link
Contributor

@jmccance jmccance commented Jan 24, 2020

(Replaces #1793)

Add support for defining arbitrary resource labels to the monitored
resource when configuring creating a time series.

Stackdriver enables associating metrics with different "monitored
resources", such as k8s_container. Monitored resources can specify
certain required "resource labels" (distinct from metric labels), such
as pod_name for k8s_container. Any metric submitted to that resource
type without all of the required resource labels will be rejected. By
enabling arbitrary resource labels to be defined in StackdriverConfig,
we'll enable more flexible integration with Stackdriver.

Add support for defining arbitrary resource labels to the monitored
resource when configuring creating a time series.

Stackdriver enables associating metrics with different "monitored
resources", such as `k8s_container`. Monitored resources can specify
certain required "resource labels" (distinct from metric labels), such
as `pod_name` for `k8s_container`. Any metric submitted to that resource
type without all of the required resource labels will be rejected. By
enabling arbitrary resource labels to be defined in StackdriverConfig,
we'll enable more flexible integration with Stackdriver.
@shakuzen shakuzen added enhancement A general enhancement registry: stackdriver A StackDriver Registry related issue labels Jan 27, 2020
@shakuzen shakuzen added this to the 1.4.0 milestone Jan 27, 2020
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me.

@shakuzen shakuzen merged commit 3673479 into micrometer-metrics:master Mar 8, 2020
@jmccance jmccance deleted the stackdriver-resource-labels branch March 9, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement registry: stackdriver A StackDriver Registry related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants