Support ZGC Cycles MXBean #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Java 17, the GarbageCollectorMXBean for ZGC has been split into `ZGC Pauses` and `ZGC Cycles`, which allows us to properly measure the pause time and the concurrent collection time. Before we only had access to the overall time. Resolves micrometer-metricsgh-2372
shakuzen
commented
Sep 27, 2021
| @@ -61,6 +73,49 @@ void metersAreBound() { | |||
| assertThat(registry.find("jvm.gc.memory.promoted").counter()).isNotNull(); | |||
| } | |||
|
|
|||
| @Test | |||
| @Disabled("Garbage collection can happen before JvmGcMetrics are registered, making our metrics not match overall counts/timings") | |||
There was a problem hiding this comment.
While the test worked consistently for me on IntelliJ with ZGC and Shenandoah, it failed on the command line because of GC happening before JvmGcMetrics is registered, so the information in the GarbageCollectorMXBeans and our metrics do not add up. This is the issue described in #2561.
jonatan-ivanov
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Java 17, the GarbageCollectorMXBean for ZGC has been split into
ZGC PausesandZGC Cycles, which allows us to properly measure the pause time and the concurrent collection time. Before we only had access to the overall time.Resolves gh-2372