Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Secret Manager Integration: Allow configurable arbitrary secret prefixes #1442

Closed
ChristianMattarVT opened this issue Aug 24, 2022 · 2 comments · Fixed by #1610
Closed
Labels
info: good first issue Good for newcomers type: enhancement New feature or request

Comments

@ChristianMattarVT
Copy link

Feature description

I've been investigating the Micronaut AWS Secret Manager integration. Initial setup works like a charm.
However, in our setup we have several secrets which are shared in various ways among different applications, e.g.
Secret 1 is used by Application A and Application B
Secret 2 is used by Application B and Application C.

The AWS IAM permissions are set up so that each application only has access to secrets that it sees.
If we make the secrets available using a common prefix (e.g. based on commonApplicationName), then, once Micronaut encounters a secret to which it has no access, it will stop fetching due to the exception.

Some ideas for improvements:

  • Allow an arbitrarily configurable list of secrets to scan, instead of just based on applicationName and commonApplicationName
  • Recover gracefully when iterating through all the listed secrets, and one is encountered where access is denied. This would allow to scan all secrets that are stored and just load those that are accessible.

Thank you!

@graemerocher graemerocher added type: enhancement New feature or request info: good first issue Good for newcomers labels Dec 2, 2022
@breader124
Copy link
Contributor

Hey, I'll try to solve it

@breader124
Copy link
Contributor

I managed to reproduce the issue described in the first post and will continue working on it

breader124 pushed a commit to breader124/micronaut-aws that referenced this issue Feb 12, 2023
breader124 pushed a commit to breader124/micronaut-aws that referenced this issue Feb 12, 2023
breader124 pushed a commit to breader124/micronaut-aws that referenced this issue Feb 12, 2023
breader124 pushed a commit to breader124/micronaut-aws that referenced this issue Feb 12, 2023
breader124 added a commit to breader124/micronaut-aws that referenced this issue Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info: good first issue Good for newcomers type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants