fix: Populate AWSProxyResponse headers with multi #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
|
Kudos, SonarCloud Quality Gate passed! |
graemerocher
requested changes
Nov 17, 2022
|
|
||
| private static Map<String, String> getHeaders(AwsProxyResponse awsProxyResponse) { | ||
| Headers multiValueHeaders = awsProxyResponse.getMultiValueHeaders(); | ||
| Map<String, String> headers = new HashMap<>(); |
There was a problem hiding this comment.
use a linked hash map to retain order
There was a problem hiding this comment.
resolved via 0f624cb
| Map<String, String> headers = new HashMap<>(); | ||
| for (Map.Entry<String, List<String>> entry : multiValueHeaders.entrySet()) { | ||
| List<String> headerValues = entry.getValue(); | ||
| if (headerValues != null && headerValues.size() == 1) { |
There was a problem hiding this comment.
Use iterator.hasNext() and iterator.next() instead of calling size() and get(0) which is less efficient
There was a problem hiding this comment.
check: No headers will be added if the size > 1, is this intended?
suggestion: Try this instead headerValues.stream().first().ifPresent(value -> headers.put(entry.getKey(), value));
There was a problem hiding this comment.
resolved via 52b852e
...ion-aws-api-proxy/src/main/java/io/micronaut/function/aws/proxy/MicronautResponseWriter.java
Outdated
Show resolved
Hide resolved
…/proxy/MicronautResponseWriter.java Co-authored-by: Thobias Karlsson <thobias.karlsson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1330