build: use Micronaut Framework 4.0.0-SNAPSHOT #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
force-pushed
the
4.0.x
branch
4 times, most recently
from
3759b96
to
1610643
Compare
|
@dstepanov maybe you can help me out. We have to modify the code to use the new API introduced here micronaut-projects/micronaut-core#8217 ./gradlew :function-aws-api-proxy:compileJava
Type-safe project accessors is an incubating feature.
Project accessors enabled, but root project name not explicitly set for 'buildSrc'. Checking out the project in different folders will impact the generated code and implicitly the buildscript classpath, breaking caching.
> Task :function-aws-api-proxy:compileJava
warning: unknown enum constant When.MAYBE
reason: class file for javax.annotation.meta.When not found
Note: Creating bean classes for 7 type elements
warning: unknown enum constant When.MAYBE
reason: class file for javax.annotation.meta.When not found
warning: unknown enum constant When.MAYBE
reason: class file for javax.annotation.meta.When not found
warning: unknown enum constant When.MAYBE
reason: class file for javax.annotation.meta.When not found
/Users/sdelamo/github/micronaut-projects/micronaut-aws/function-aws-api-proxy/src/main/java/io/micronaut/function/aws/proxy/MicronautAwsProxyResponse.java:228: error: MicronautAwsProxyResponse.AwsHeaders is not abstract and does not override abstract method setConversionService(ConversionService) in ConversionServiceAware
private class AwsHeaders implements MutableHttpHeaders {
^
/Users/sdelamo/github/micronaut-projects/micronaut-aws/function-aws-api-proxy/src/main/java/io/micronaut/function/aws/proxy/MicronautLambdaContainerHandler.java:360: error: no suitable method found for executeRoute(MicronautAwsProxyRequest<CAP#1>,boolean,Flux<RouteMatch<?>>)
routeResponse = routeExecutor.executeRoute(
^
method RouteExecutor.executeRoute(RequestBodyReader,HttpRequest<?>,boolean,StaticResourceResponseFinder) is not applicable
(actual and formal argument lists differ in length)
method RouteExecutor.executeRoute(AtomicReference<HttpRequest<?>>,boolean,boolean,ExecutionFlow<RouteMatch<?>>) is not applicable
(actual and formal argument lists differ in length)
where CAP#1 is a fresh type-variable:
CAP#1 extends Object from capture of ?
/Users/sdelamo/github/micronaut-projects/micronaut-aws/function-aws-api-proxy/src/main/java/io/micronaut/function/aws/proxy/MicronautLambdaContainerHandler.java:366: error: incompatible types: ExecutionFlow<MutableHttpResponse<?>> cannot be converted to Supplier<ExecutionFlow<MutableHttpResponse<?>>>
routeResponse = Flux.from(routeE`xecutor.filterPublisher(new AtomicReference<>(request), routeExecutor.onError(e, request)));
^
/Users/sdelamo/github/micronaut-projects/micronaut-aws/function-aws-api-proxy/src/main/java/io/micronaut/function/aws/proxy/MicronautLambdaContainerHandler.java:710: error: incompatible types: Publisher<MutableHttpResponse<?>> cannot be converted to Supplier<ExecutionFlow<MutableHttpResponse<?>>>
Flux.from(routeExecutor.filterPublisher(requestReference, responsePublisher))Moreover, Also, this fails: @dstepanov It seems you removed AstAnnotationUtils here: micronaut-projects/micronaut-core@752a221#diff-12d26803929b8b3d13e678348c0a42048673cc40649cc7bdda4c41b88e70e5aa |
Untested, can't get the snapshot to run locally. Most of the code that I removed seems to be identical with RouteExecutor (or, now, RequestLifecycle), however I may have missed some differences.
This test relied on method order before: When no version was supplied, it would pick the first available route. The use of RequestLifecycle changes this to an error (ambiguous route), which is the correct behavior. I've patched the test so that the route choice is unambiguous.
Use new RequestLifecycle api
|
❌ Java CI failed: https://ge.micronaut.io/s/rwh5i3pbx7zqa |
|
❌ GraalVM CE CI 17 latest failed: https://ge.micronaut.io/s/i42pkw65h7oyu |
|
❌ Java CI failed: https://ge.micronaut.io/s/mrflyzhb642yc |
|
Investigating the failure with Cloudwatch logging |
|
@sdelamo Ready for review 👍 |
sdelamo
commented
Jan 31, 2023
|
❌ GraalVM CE CI 17 latest failed: https://ge.micronaut.io/s/ryvgjwngdydnk |
|
❌ Java CI failed: https://ge.micronaut.io/s/paiwplhl7gbi4 |
|
Fixed the TCK build script, we seem to have a couple of TCK failures ion the ErrorHandlerTest, I will investigate |
|
❌ GraalVM CE CI 19 dev failed: https://ge.micronaut.io/s/cxoe7sdx4r6bq |
|
❌ Java CI failed: https://ge.micronaut.io/s/pmjagcdhiepo4 |
timyates
approved these changes
Feb 2, 2023
|
SonarCloud Quality Gate failed. |
|
@sdelamo 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.