Fix for drive-by localhost cors deny TCK test #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the filter blocks access to localhost from a non-local origin, there is no ROUTE_INFO set on the response object. Previously, we just called get() on the Optional. This fails. I believe the fix is to only continue processing the response if the ROUTE_INFO has been applied to the response.
|
Unsure why we're not running 3.13 against java 8 and 11? |
|
Seems to have been done here on the 15th Dec #1530 |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the filter blocks access to localhost from a non-local origin, there is no ROUTE_INFO set on the response object.
Previously, we just called get() on the Optional. This fails.
I believe the fix is to only continue processing the response if the ROUTE_INFO has been applied to the response.